[clang-tools-extra] [clang-tidy] Stop linking against clangSema (PR #113373)

via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 22 12:48:21 PDT 2024


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-clang-tidy

Author: Vlad Serebrennikov (Endilll)

<details>
<summary>Changes</summary>

This is bad layering-wise. The only fix needed now is to anchor `SemaConsumer` vtable, which is also done in this patch.

---
Full diff: https://github.com/llvm/llvm-project/pull/113373.diff


2 Files Affected:

- (modified) clang-tools-extra/clang-tidy/CMakeLists.txt (-1) 
- (modified) clang-tools-extra/clang-tidy/ClangTidy.cpp (+1) 


``````````diff
diff --git a/clang-tools-extra/clang-tidy/CMakeLists.txt b/clang-tools-extra/clang-tidy/CMakeLists.txt
index 83a3236131dc93..93117cf1d6373a 100644
--- a/clang-tools-extra/clang-tidy/CMakeLists.txt
+++ b/clang-tools-extra/clang-tidy/CMakeLists.txt
@@ -35,7 +35,6 @@ clang_target_link_libraries(clangTidy
   clangFrontend
   clangLex
   clangRewrite
-  clangSema
   clangSerialization
   clangTooling
   clangToolingCore
diff --git a/clang-tools-extra/clang-tidy/ClangTidy.cpp b/clang-tools-extra/clang-tidy/ClangTidy.cpp
index c4cac7d27b77c2..9c8c93c5d16c72 100644
--- a/clang-tools-extra/clang-tidy/ClangTidy.cpp
+++ b/clang-tools-extra/clang-tidy/ClangTidy.cpp
@@ -336,6 +336,7 @@ class ClangTidyASTConsumer : public MultiplexConsumer {
   std::unique_ptr<ClangTidyProfiling> Profiling;
   std::unique_ptr<ast_matchers::MatchFinder> Finder;
   std::vector<std::unique_ptr<ClangTidyCheck>> Checks;
+  void anchor() override {};
 };
 
 } // namespace

``````````

</details>


https://github.com/llvm/llvm-project/pull/113373


More information about the cfe-commits mailing list