[clang] [llvm] [llvm] Support llvm::Any across shared libraries on windows (PR #108051)
Thomas Fransham via cfe-commits
cfe-commits at lists.llvm.org
Tue Oct 22 10:38:00 PDT 2024
fsfod wrote:
> > @ymand, is your concern resolved?
>
> Sorry, it isn't -- a) we still need comments with at least minimal explanation and b) I'm not sure why the definition is now in TypeErasedDataflowAnalysis.cpp -- is this because we lack NoopAnalysis.cpp? If so, why is TypeErasedDataflowAnalysis.cpp then the right place? or, should we create a NoopAnalysis.cpp?
Yes there was no NoopAnalysis.cpp, if you fine with me creating one just to only contain an explicit instantiation i can move it there.
https://github.com/llvm/llvm-project/pull/108051
More information about the cfe-commits
mailing list