[clang] [Clang][HIP] Deprecate the AMDGCN_WAVEFRONT_SIZE macros (PR #112849)

[Matt Arsenault via cfe-commits]

================
@@ -26,8 +27,14 @@ class MacroBuilder {
   MacroBuilder(raw_ostream &Output) : Out(Output) {}
 
   /// Append a \#define line for macro of the form "\#define Name Value\n".
-  void defineMacro(const Twine &Name, const Twine &Value = "1") {
+  /// If DeprecationMsg is provided, also append a pragma to deprecate the
+  /// defined macro.
+  void defineMacro(const Twine &Name, const Twine &Value = "1",
+                   std::optional<Twine> DeprecationMsg = std::nullopt) {
----------------
arsenm wrote:

Just use Twine with a default ""? Shouldn't have a value twine optional 

https://github.com/llvm/llvm-project/pull/112849