[clang] [llvm] Adding splitdouble HLSL function (PR #109331)

Tex Riddell via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 18 17:27:07 PDT 2024


================
@@ -1698,18 +1698,27 @@ static bool CheckVectorElementCallArgs(Sema *S, CallExpr *TheCall) {
   return true;
 }
 
-static bool CheckArgsTypesAreCorrect(
+bool CheckArgTypeIsIncorrect(
----------------
tex3d wrote:

This switches the naming pattern from the existing convention.  Why?  It makes me think: "Make sure the arg type is incorrect".  I know that the other functions return true on failure and false on success, but that's just the standard convention for sema checking functions.

https://github.com/llvm/llvm-project/pull/109331


More information about the cfe-commits mailing list