[clang] [Sema] Fix warnings in SemaFunctionEffects.cpp (PR #112857)

Karl-Johan Karlsson via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 18 02:11:37 PDT 2024


https://github.com/karka228 created https://github.com/llvm/llvm-project/pull/112857

Fix gcc warnings like:
SemaFunctionEffects.cpp:1531:5: warning: this statement may fall through [-Wimplicit-fallthrough=]

>From ba5358f12c84266c4527d0e045055b10eabe4a0f Mon Sep 17 00:00:00 2001
From: Karl-Johan Karlsson <karl-johan.karlsson at ericsson.com>
Date: Fri, 18 Oct 2024 10:39:09 +0200
Subject: [PATCH] [Sema] Fix warnings in SemaFunctionEffects.cpp

Fix gcc warnings like:
SemaFunctionEffects.cpp:1531:5: warning: this statement may fall through [-Wimplicit-fallthrough=]
---
 clang/lib/Sema/SemaFunctionEffects.cpp | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/clang/lib/Sema/SemaFunctionEffects.cpp b/clang/lib/Sema/SemaFunctionEffects.cpp
index 70e5d78661a835..c3e2a2d856a283 100644
--- a/clang/lib/Sema/SemaFunctionEffects.cpp
+++ b/clang/lib/Sema/SemaFunctionEffects.cpp
@@ -1540,6 +1540,7 @@ bool Sema::FunctionEffectDiff::shouldDiagnoseConversion(
       // matching is better.
       return true;
     }
+    break;
   case FunctionEffect::Kind::Blocking:
   case FunctionEffect::Kind::Allocating:
     return false;
@@ -1563,6 +1564,7 @@ bool Sema::FunctionEffectDiff::shouldDiagnoseRedeclaration(
       // All these forms of mismatches are diagnosed.
       return true;
     }
+    break;
   case FunctionEffect::Kind::Blocking:
   case FunctionEffect::Kind::Allocating:
     return false;
@@ -1592,6 +1594,7 @@ Sema::FunctionEffectDiff::shouldDiagnoseMethodOverride(
     case Kind::ConditionMismatch:
       return OverrideResult::Warn;
     }
+    break;
 
   case FunctionEffect::Kind::Blocking:
   case FunctionEffect::Kind::Allocating:



More information about the cfe-commits mailing list