[clang] [clang][bytecode] Activate pointers in Init{, Pop} (PR #112832)
via cfe-commits
cfe-commits at lists.llvm.org
Thu Oct 17 21:01:16 PDT 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-clang
Author: Timm Baeder (tbaederr)
<details>
<summary>Changes</summary>
---
Full diff: https://github.com/llvm/llvm-project/pull/112832.diff
2 Files Affected:
- (modified) clang/lib/AST/ByteCode/Interp.h (+2)
- (modified) clang/test/AST/ByteCode/placement-new.cpp (+11)
``````````diff
diff --git a/clang/lib/AST/ByteCode/Interp.h b/clang/lib/AST/ByteCode/Interp.h
index dece95971b7617..ff5bb94a74c83e 100644
--- a/clang/lib/AST/ByteCode/Interp.h
+++ b/clang/lib/AST/ByteCode/Interp.h
@@ -1841,6 +1841,7 @@ bool Init(InterpState &S, CodePtr OpPC) {
assert(false);
return false;
}
+ Ptr.activate();
Ptr.initialize();
new (&Ptr.deref<T>()) T(Value);
return true;
@@ -1852,6 +1853,7 @@ bool InitPop(InterpState &S, CodePtr OpPC) {
const Pointer &Ptr = S.Stk.pop<Pointer>();
if (!CheckInit(S, OpPC, Ptr))
return false;
+ Ptr.activate();
Ptr.initialize();
new (&Ptr.deref<T>()) T(Value);
return true;
diff --git a/clang/test/AST/ByteCode/placement-new.cpp b/clang/test/AST/ByteCode/placement-new.cpp
index caf3ac97fd1c04..eb8311c283e30a 100644
--- a/clang/test/AST/ByteCode/placement-new.cpp
+++ b/clang/test/AST/ByteCode/placement-new.cpp
@@ -286,3 +286,14 @@ namespace UsedToCrash {
}
int alloc1 = (alloc(), 0);
}
+
+constexpr bool change_union_member() {
+ union U {
+ int a;
+ int b;
+ };
+ U u = {.a = 1};
+ std::construct_at<int>(&u.b, 2);
+ return u.b == 2;
+}
+static_assert(change_union_member());
``````````
</details>
https://github.com/llvm/llvm-project/pull/112832
More information about the cfe-commits
mailing list