[clang] [llvm] [clang][llvm][SPIR-V] Explicitly encode native integer widths for SPIR-V (PR #110695)
Alex Voicu via cfe-commits
cfe-commits at lists.llvm.org
Thu Oct 17 14:11:03 PDT 2024
================
@@ -1,12 +1,14 @@
; This test aims to check ability to support "Arithmetic with Overflow" intrinsics
; in the special case when those intrinsics are being generated by the CodeGenPrepare;
-; pass during translations with optimization (note -O3 in llc arguments).
+; pass during translations with optimization (note -disable-lsr, to inhibit
+; strength reduction pre-empting with a more preferable match for this pattern
+; in llc arguments).
-; RUN: llc -O3 -mtriple=spirv32-unknown-unknown %s -o - | FileCheck %s
-; RUN: %if spirv-tools %{ llc -O3 -mtriple=spirv32-unknown-unknown %s -o - -filetype=obj | spirv-val %}
+; RUN: llc -O3 -disable-lsr -mtriple=spirv32-unknown-unknown %s -o - | FileCheck %s
----------------
AlexVlx wrote:
I somehow get the sense that this is not the desired outcome here, at least from the SPIR-V BE side, and we're cycling between these two states (this test has to absolutely stay as it is vs it should reflect reality). It would be nice to get a conclusion one way or the other so that this can be progressed / merged, unless there are other blocking concerns. The best I can think of as a solution is to just add an additional `RUN` with LSR enabled which reflects the net result?
https://github.com/llvm/llvm-project/pull/110695
More information about the cfe-commits
mailing list