[clang] f35a14d - [HLSL] Simplify debug check in ResourceBindings::addDeclBindingInfo (#112661)

[via cfe-commits]

Author: Helena Kotas
Date: 2024-10-17T10:17:09-07:00
New Revision: f35a14dd507b6fc90fe8e0b606c2f787d7dfedea

URL: https://github.com/llvm/llvm-project/commit/f35a14dd507b6fc90fe8e0b606c2f787d7dfedea
DIFF: https://github.com/llvm/llvm-project/commit/f35a14dd507b6fc90fe8e0b606c2f787d7dfedea.diff

LOG: [HLSL] Simplify debug check in ResourceBindings::addDeclBindingInfo (#112661)

Follow-up for
https://github.com/llvm/llvm-project/pull/111203#pullrequestreview-2373679837.

Added: 
    

Modified: 
    clang/lib/Sema/SemaHLSL.cpp

Removed: 
    


################################################################################
diff  --git a/clang/lib/Sema/SemaHLSL.cpp b/clang/lib/Sema/SemaHLSL.cpp
index 0d23c4935e9196..efb0fbaa432d76 100644
--- a/clang/lib/Sema/SemaHLSL.cpp
+++ b/clang/lib/Sema/SemaHLSL.cpp
@@ -110,15 +110,7 @@ DeclBindingInfo *ResourceBindings::addDeclBindingInfo(const VarDecl *VD,
                                                       ResourceClass ResClass) {
   assert(getDeclBindingInfo(VD, ResClass) == nullptr &&
          "DeclBindingInfo already added");
-#ifndef NDEBUG
-  // Verify that existing bindings for this decl are stored sequentially
-  // and at the end of the BindingsList
-  auto I = DeclToBindingListIndex.find(VD);
-  if (I != DeclToBindingListIndex.end()) {
-    for (unsigned Index = I->getSecond(); Index < BindingsList.size(); ++Index)
-      assert(BindingsList[Index].Decl == VD);
-  }
-#endif
+  assert(!hasBindingInfoForDecl(VD) || BindingsList.back().Decl == VD);
   // VarDecl may have multiple entries for 
diff erent resource classes.
   // DeclToBindingListIndex stores the index of the first binding we saw
   // for this decl. If there are any additional ones then that index