[clang] [clang-tools-extra] [analyzer][clang-tidy][NFC] Clean up eagerly-assume handling (PR #112209)

[Donát Nagy via cfe-commits]

================
@@ -458,7 +458,6 @@ ClangTidyASTConsumerFactory::createASTConsumer(
   if (!AnalyzerOptions.CheckersAndPackages.empty()) {
     setStaticAnalyzerCheckerOpts(Context.getOptions(), AnalyzerOptions);
     AnalyzerOptions.AnalysisDiagOpt = PD_NONE;
-    AnalyzerOptions.eagerlyAssumeBinOpBifurcation = true;
----------------
NagyDonat wrote:

No, this is not functionality loss from Tidy's perspective, because this data member is dead, its value doesn't influence anything. The `eagerly-assume` feature is controlled by `AnalyzerOptions.ShouldEagerlyAssume` (which is true by default).

https://github.com/llvm/llvm-project/pull/112209