[clang] [analyzer] Modernize FuchsiaHandleChecker (PR #111588)

[Gábor Horváth via cfe-commits]

Xazax-hun wrote:

> I thougth evalCall approach is more clean.

It is definitely more clean locally. My concerns is about the global behavior. Imagine a function that deals with both Fuchsia handles and plain old C file handles. If we start to do evalCall and no longer inline the body, we no longer get the modeling for `fopen` and `fclose` calls in that body from the C stream checkers. 

This is the main problem with evalCall, it does not really compose. 

https://github.com/llvm/llvm-project/pull/111588