[clang] [AST] Avoid repeated set lookups (NFC) (PR #112155)
via cfe-commits
cfe-commits at lists.llvm.org
Sun Oct 13 21:02:13 PDT 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-clang
Author: Kazu Hirata (kazutakahirata)
<details>
<summary>Changes</summary>
---
Full diff: https://github.com/llvm/llvm-project/pull/112155.diff
1 Files Affected:
- (modified) clang/lib/AST/InheritViz.cpp (+1-2)
``````````diff
diff --git a/clang/lib/AST/InheritViz.cpp b/clang/lib/AST/InheritViz.cpp
index 2ed0ce1c79c5bd..1dafed837a3560 100644
--- a/clang/lib/AST/InheritViz.cpp
+++ b/clang/lib/AST/InheritViz.cpp
@@ -63,12 +63,11 @@ void InheritanceHierarchyWriter::WriteNode(QualType Type, bool FromVirtual) {
QualType CanonType = Context.getCanonicalType(Type);
if (FromVirtual) {
- if (KnownVirtualBases.find(CanonType) != KnownVirtualBases.end())
+ if (!KnownVirtualBases.insert(CanonType).second)
return;
// We haven't seen this virtual base before, so display it and
// its bases.
- KnownVirtualBases.insert(CanonType);
}
// Declare the node itself.
``````````
</details>
https://github.com/llvm/llvm-project/pull/112155
More information about the cfe-commits
mailing list