[clang] [llvm] [mlir] [polly] [NFC] Rename `Intrinsic::getDeclaration` to `getOrInsertDeclaration` (PR #111752)

[Rahul Joshi via cfe-commits]

jurahul wrote:

Thanks. So it seems we have 2 ways forwards:

1. Add back getDeclaration, marked deprecated, and then delete it in say
2-3 weeks, and then reintroduce it with different semantics 6 months down
the road. Meanwhile, add findDeclaration as an alias, start using it, and
then 6 months down the road, we will have getDeclaration as well, so
another 6 months to finally remove findDeclaration. I find that
surprisingly prolonged process for C++ API that LLVM has not stability
guarantees even on a day to day basis.

2. Revert the change, and go back to your earlier proposal of
getDeclaration and getDeclarationIfExists, and live with lack of naming
consistency between Module:: and Intrinsic:: members that do similar things.

Does that sound right?

On Sun, Oct 13, 2024 at 5:02 AM Nikita Popov ***@***.***>
wrote:

> To reuse the name with different semantics, I'd put removal and reuse in
> different releases, so it takes about half a year. (Deprecation itself can
> be very short-lived.)
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/llvm/llvm-project/pull/111752#issuecomment-2408950768>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/APRMUB7YRNGO2MYJETG3DXLZ3JOL7AVCNFSM6AAAAABPVHZ3QGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBYHE2TANZWHA>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>


https://github.com/llvm/llvm-project/pull/111752