[clang] [llvm] [mlir] [polly] [NFC] Rename `Intrinsic::getDeclaration` to `getOrInsertDeclaration` (PR #111752)

[Rahul Joshi via cfe-commits]

jurahul wrote:

You’re right. Though I am hoping to add a new function with that name and a
different behavior. But I can see how this might be problematic for out of
tree backends as well as that code will compile fine but might fail at
runtime with the new function. I can call the function “findDeclaration”
instead of “getDeclaration” and then do a rename later down the road
(following the recipe you suggested)

On Fri, Oct 11, 2024 at 2:10 PM Arthur Eubanks ***@***.***>
wrote:

> for such a wide-reaching change, it would have been nice to add the new
> function in one commit, update users in other commits, then remove the old
> function in one last commit. makes it easier to revert the removal of the
> old function, and makes it easier for out of tree users to to migrate
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/llvm/llvm-project/pull/111752#issuecomment-2408124177>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/APRMUB7TBNWKFUDORGE7CU3Z3A5ETAVCNFSM6AAAAABPVHZ3QGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBYGEZDIMJXG4>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>


https://github.com/llvm/llvm-project/pull/111752