[clang] [llvm] [clang][llvm][SPIR-V] Explicitly encode native integer widths for SPIR-V (PR #110695)

Alex Voicu via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 11 04:32:26 PDT 2024


AlexVlx wrote:

> > InstCombine's primary function is a canonicalization pass. You shouldn't be modifying it for specifically SPIRV optimizations (with the exception of SPIRV intrinsic support). SPIRV specific transforms belong in later backend IR passes
> 
> Does it mean, that the reasoning behind this very PR is not legit?
> 
> > This is problematic as it leads to optimisation passes, such as InstCombine, getting ideas and e.g. shrinking to non byte-multiple integer types, which is not desirable and can lead to breakage further down in the toolchain.

This is not SPIR-V specific, it addresses a SPIR-V issue on the SPIR-V side, not in InstCombine.

https://github.com/llvm/llvm-project/pull/110695


More information about the cfe-commits mailing list