[clang] [compiler-rt] [XRay] Add support for instrumentation of DSOs on x86_64 (PR #90959)

Fri Oct 11 03:07:11 PDT 2024

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `clang-ppc64le-linux-multistage` running on `ppc64le-clang-multistage-test` while building `clang,compiler-rt` at step 4 "build stage 1".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/76/builds/3589

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 4 (build stage 1) failure: 'ninja' (failure)
...
[294/529] Building CXX object compiler-rt/lib/asan/CMakeFiles/RTAsan_dynamic.powerpc64le.dir/asan_suppressions.cpp.o
[295/529] Building ASM object compiler-rt/lib/orc/CMakeFiles/RTOrc.powerpc64le.dir/elfnix_tls.ppc64.S.o
[296/529] Building CXX object compiler-rt/lib/sanitizer_common/CMakeFiles/RTSanitizerCommon.powerpc64le.dir/sanitizer_posix.cpp.o
[297/529] Building CXX object compiler-rt/lib/asan/CMakeFiles/RTAsan.powerpc64le.dir/asan_suppressions.cpp.o
[298/529] Building CXX object compiler-rt/lib/scudo/standalone/CMakeFiles/clang_rt.scudo_standalone-dynamic-powerpc64le.dir/linux.cpp.o
[299/529] Building CXX object compiler-rt/lib/sanitizer_common/CMakeFiles/RTSanitizerCommonSymbolizer.powerpc64le.dir/sanitizer_symbolizer_markup.cpp.o
[300/529] Building CXX object compiler-rt/lib/sanitizer_common/CMakeFiles/RTSanitizerCommon.powerpc64le.dir/sanitizer_flags.cpp.o
[301/529] Building C object compiler-rt/lib/profile/CMakeFiles/clang_rt.profile-powerpc64le.dir/InstrProfilingMerge.c.o
[302/529] Building CXX object compiler-rt/lib/scudo/standalone/CMakeFiles/clang_rt.scudo_standalone-dynamic-powerpc64le.dir/report_linux.cpp.o
[303/529] Building CXX object compiler-rt/lib/xray/CMakeFiles/RTXray.powerpc64le.dir/xray_interface.cpp.o
FAILED: compiler-rt/lib/xray/CMakeFiles/RTXray.powerpc64le.dir/xray_interface.cpp.o 
/home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-multistage-test/clang-ppc64le-multistage/stage1/./bin/clang++ --target=powerpc64le-unknown-linux-gnu -DSANITIZER_COMMON_NO_REDEFINE_BUILTINS -DXRAY_HAS_EXCEPTIONS=1 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-multistage-test/clang-ppc64le-multistage/llvm/compiler-rt/lib/xray/.. -I/home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-multistage-test/clang-ppc64le-multistage/llvm/compiler-rt/lib/xray/../../include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -Wall -Wno-unused-parameter -O3 -DNDEBUG -std=c++17 -m64 -fno-function-sections -fPIC -fno-builtin -fno-exceptions -fomit-frame-pointer -funwind-tables -fno-stack-protector -fno-sanitize=safe-stack -fvisibility=hidden -fno-lto -Wthread-safety -Wthread-safety-reference -Wthread-safety-beta -O3 -gline-tables-only -Wno-gnu -Wno-variadic-macros -Wno-c99-extensions -Wno-format -fno-rtti -MD -MT compiler-rt/lib/xray/CMakeFiles/RTXray.powerpc64le.dir/xray_interface.cpp.o -MF compiler-rt/lib/xray/CMakeFiles/RTXray.powerpc64le.dir/xray_interface.cpp.o.d -o compiler-rt/lib/xray/CMakeFiles/RTXray.powerpc64le.dir/xray_interface.cpp.o -c /home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-multistage-test/clang-ppc64le-multistage/llvm/compiler-rt/lib/xray/xray_interface.cpp
/home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-multistage-test/clang-ppc64le-multistage/llvm/compiler-rt/lib/xray/xray_interface.cpp:16:10: fatal error: 'llvm/Support/ErrorHandling.h' file not found
   16 | #include "llvm/Support/ErrorHandling.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
[304/529] Building CXX object compiler-rt/lib/lsan/CMakeFiles/clang_rt.lsan-powerpc64le.dir/lsan_thread.cpp.o
[305/529] Building CXX object compiler-rt/lib/scudo/standalone/CMakeFiles/clang_rt.scudo_standalone-powerpc64le.dir/linux.cpp.o
[306/529] Building CXX object compiler-rt/lib/sanitizer_common/CMakeFiles/RTSanitizerCommon.powerpc64le.dir/sanitizer_printf.cpp.o
[307/529] Building CXX object compiler-rt/lib/sanitizer_common/CMakeFiles/RTSanitizerCommonNoTermination.powerpc64le.dir/sanitizer_common.cpp.o
[308/529] Building CXX object compiler-rt/lib/xray/CMakeFiles/RTXray.powerpc64le.dir/xray_log_interface.cpp.o
[309/529] Building CXX object compiler-rt/lib/scudo/standalone/CMakeFiles/RTScudoStandalone.powerpc64le.dir/mem_map_linux.cpp.o
[310/529] Building CXX object compiler-rt/lib/msan/CMakeFiles/clang_rt.msan_cxx-powerpc64le.dir/msan_new_delete.cpp.o
[311/529] Building CXX object compiler-rt/lib/scudo/standalone/CMakeFiles/clang_rt.scudo_standalone-dynamic-powerpc64le.dir/mem_map_linux.cpp.o
[312/529] Building CXX object compiler-rt/lib/sanitizer_common/CMakeFiles/RTSanitizerCommonLibc.powerpc64le.dir/sanitizer_posix_libcdep.cpp.o
[313/529] Building CXX object compiler-rt/lib/sanitizer_common/CMakeFiles/RTSanitizerCommonNoTermination.powerpc64le.dir/sanitizer_printf.cpp.o
[314/529] Building CXX object compiler-rt/lib/asan/CMakeFiles/RTAsan_dynamic.powerpc64le.dir/asan_memory_profile.cpp.o
[315/529] Building CXX object compiler-rt/lib/sanitizer_common/CMakeFiles/RTSanitizerCommonSymbolizerNoHooks.powerpc64le.dir/sanitizer_stacktrace_libcdep.cpp.o
[316/529] Building CXX object compiler-rt/lib/sanitizer_common/CMakeFiles/RTSanitizerCommonSymbolizerNoHooks.powerpc64le.dir/sanitizer_symbolizer_markup.cpp.o
[317/529] Building CXX object compiler-rt/lib/asan/CMakeFiles/RTAsan_dynamic.powerpc64le.dir/asan_linux.cpp.o
[318/529] Building CXX object compiler-rt/lib/stats/CMakeFiles/clang_rt.stats-powerpc64le.dir/stats.cpp.o
[319/529] Building CXX object compiler-rt/lib/scudo/standalone/CMakeFiles/RTScudoStandalone.powerpc64le.dir/timing.cpp.o
[320/529] Building CXX object compiler-rt/lib/sanitizer_common/CMakeFiles/RTSanitizerCommonNoTermination.powerpc64le.dir/sanitizer_suppressions.cpp.o
[321/529] Building CXX object compiler-rt/lib/sanitizer_common/CMakeFiles/RTSanitizerCommonNoHooks.powerpc64le.dir/sanitizer_common.cpp.o
[322/529] Building CXX object compiler-rt/lib/asan/CMakeFiles/RTAsan_dynamic.powerpc64le.dir/asan_activation.cpp.o
[323/529] Building C object compiler-rt/lib/profile/CMakeFiles/clang_rt.profile-powerpc64le.dir/InstrProfilingFile.c.o
[324/529] Building CXX object compiler-rt/lib/tsan/rtl/CMakeFiles/clang_rt.tsan-powerpc64le.dir/tsan_rtl_proc.cpp.o
[325/529] Building CXX object compiler-rt/lib/asan/CMakeFiles/RTAsan.powerpc64le.dir/asan_debugging.cpp.o
[326/529] Building CXX object compiler-rt/lib/sanitizer_common/CMakeFiles/RTSanitizerCommon.powerpc64le.dir/sanitizer_common.cpp.o
[327/529] Building CXX object compiler-rt/lib/scudo/standalone/CMakeFiles/clang_rt.scudo_standalone-dynamic-powerpc64le.dir/report.cpp.o
[328/529] Building CXX object compiler-rt/lib/sanitizer_common/CMakeFiles/RTSanitizerCommonNoHooks.powerpc64le.dir/sanitizer_posix.cpp.o
[329/529] Building CXX object compiler-rt/lib/ubsan/CMakeFiles/RTUbsan_cxx.powerpc64le.dir/ubsan_handlers_cxx.cpp.o
[330/529] Building CXX object compiler-rt/lib/tsan/rtl/CMakeFiles/clang_rt.tsan-powerpc64le.dir/tsan_vector_clock.cpp.o
[331/529] Building CXX object compiler-rt/lib/tsan/rtl/CMakeFiles/clang_rt.tsan-powerpc64le.dir/tsan_md5.cpp.o
[332/529] Building CXX object compiler-rt/lib/scudo/standalone/CMakeFiles/RTScudoStandalone.powerpc64le.dir/linux.cpp.o
[333/529] Building CXX object compiler-rt/lib/xray/CMakeFiles/RTXray.powerpc64le.dir/xray_init.cpp.o
/home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-multistage-test/clang-ppc64le-multistage/llvm/compiler-rt/lib/xray/xray_init.cpp:213:27: warning: comparison of integers of different signs: 'int32_t' (aka 'int') and 'size_t' (aka 'unsigned long') [-Wsign-compare]
  213 |   if (ObjId <= 0 || ObjId >= __xray_num_objects()) {
      |                     ~~~~~ ^  ~~~~~~~~~~~~~~~~~~~~

```

</details>

https://github.com/llvm/llvm-project/pull/90959