[clang] [llvm] [clang][llvm][SPIR-V] Explicitly encode native integer widths for SPIR-V (PR #110695)

Alex Voicu via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 11 03:00:47 PDT 2024


================
@@ -1,12 +1,14 @@
 ; This test aims to check ability to support "Arithmetic with Overflow" intrinsics
 ; in the special case when those intrinsics are being generated by the CodeGenPrepare;
-; pass during translations with optimization (note -O3 in llc arguments).
+; pass during translations with optimization (note -disable-lsr, to inhibit
+; strength reduction pre-empting with a more preferable match for this pattern
+; in llc arguments).
 
-; RUN: llc -O3 -mtriple=spirv32-unknown-unknown %s -o - | FileCheck %s
-; RUN: %if spirv-tools %{ llc -O3 -mtriple=spirv32-unknown-unknown %s -o - -filetype=obj | spirv-val %}
+; RUN: llc -O3 -disable-lsr -mtriple=spirv32-unknown-unknown %s -o - | FileCheck %s
----------------
AlexVlx wrote:

I'm afraid I'm not quite sure how to parse that: the BE processing would happen later, and these / the IR would not look at all different from the BE's perspective. Stepping back, I don't want to die on the hill of this test: it's been restored to its prior state - I'm not exactly sure what loss of coverage you have in mind here (it does exactly the same thing now), or what the very concrete improvement is in this case.

https://github.com/llvm/llvm-project/pull/110695


More information about the cfe-commits mailing list