[clang] [compiler-rt] [XRay] Add support for instrumentation of DSOs on x86_64 (PR #90959)

Fri Oct 11 02:49:29 PDT 2024

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `clang-ppc64le-linux-test-suite` running on `ppc64le-clang-test-suite` while building `clang,compiler-rt` at step 5 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/95/builds/4912

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 5 (build-unified-tree) failure: build (failure)
...
1 warning generated.
0.996 [37/190/303] Building CXX object compiler-rt/lib/xray/CMakeFiles/RTXray.powerpc64le.dir/xray_log_interface.cpp.o
1.001 [37/189/304] Building CXX object compiler-rt/lib/sanitizer_common/CMakeFiles/RTSanitizerCommonSymbolizerNoHooks.powerpc64le.dir/sanitizer_stackdepot.cpp.o
1.007 [37/188/305] Building CXX object compiler-rt/lib/asan/CMakeFiles/RTAsan_dynamic.powerpc64le.dir/asan_stack.cpp.o
1.013 [37/187/306] Building C object compiler-rt/lib/profile/CMakeFiles/clang_rt.profile-powerpc64le.dir/GCDAProfiling.c.o
1.014 [37/186/307] Building CXX object compiler-rt/lib/stats/CMakeFiles/clang_rt.stats-powerpc64le.dir/stats.cpp.o
1.016 [37/185/308] Building CXX object compiler-rt/lib/sanitizer_common/CMakeFiles/RTSanitizerCommonNoHooks.powerpc64le.dir/sanitizer_libignore.cpp.o
1.030 [37/184/309] Building CXX object compiler-rt/lib/scudo/standalone/CMakeFiles/clang_rt.scudo_standalone-powerpc64le.dir/string_utils.cpp.o
1.032 [37/183/310] Building CXX object compiler-rt/lib/sanitizer_common/CMakeFiles/RTSanitizerCommonNoTermination.powerpc64le.dir/sanitizer_printf.cpp.o
1.038 [37/182/311] Building CXX object compiler-rt/lib/xray/CMakeFiles/RTXray.powerpc64le.dir/xray_interface.cpp.o
FAILED: compiler-rt/lib/xray/CMakeFiles/RTXray.powerpc64le.dir/xray_interface.cpp.o 
/home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-test-suite/clang-ppc64le-test-suite/build/./bin/clang++ --target=powerpc64le-unknown-linux-gnu -DSANITIZER_COMMON_NO_REDEFINE_BUILTINS -DXRAY_HAS_EXCEPTIONS=1 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-test-suite/clang-ppc64le-test-suite/llvm-project/compiler-rt/lib/xray/.. -I/home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-test-suite/clang-ppc64le-test-suite/llvm-project/compiler-rt/lib/xray/../../include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -Wall -Wno-unused-parameter -O3 -DNDEBUG -std=c++17 -m64 -fno-function-sections -fPIC -fno-builtin -fno-exceptions -fomit-frame-pointer -funwind-tables -fno-stack-protector -fno-sanitize=safe-stack -fvisibility=hidden -fno-lto -Wthread-safety -Wthread-safety-reference -Wthread-safety-beta -O3 -gline-tables-only -Wno-gnu -Wno-variadic-macros -Wno-c99-extensions -Wno-format -fno-rtti -MD -MT compiler-rt/lib/xray/CMakeFiles/RTXray.powerpc64le.dir/xray_interface.cpp.o -MF compiler-rt/lib/xray/CMakeFiles/RTXray.powerpc64le.dir/xray_interface.cpp.o.d -o compiler-rt/lib/xray/CMakeFiles/RTXray.powerpc64le.dir/xray_interface.cpp.o -c /home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-test-suite/clang-ppc64le-test-suite/llvm-project/compiler-rt/lib/xray/xray_interface.cpp
/home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-test-suite/clang-ppc64le-test-suite/llvm-project/compiler-rt/lib/xray/xray_interface.cpp:16:10: fatal error: 'llvm/Support/ErrorHandling.h' file not found
   16 | #include "llvm/Support/ErrorHandling.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
1.039 [37/181/312] Building CXX object compiler-rt/lib/tsan/rtl/CMakeFiles/clang_rt.tsan-powerpc64le.dir/tsan_mutexset.cpp.o
1.042 [37/180/313] Building CXX object compiler-rt/lib/sanitizer_common/CMakeFiles/RTSanitizerCommon.powerpc64le.dir/sanitizer_flags.cpp.o
1.043 [37/179/314] Building CXX object compiler-rt/lib/asan/CMakeFiles/RTAsan_dynamic.powerpc64le.dir/asan_flags.cpp.o
1.044 [37/178/315] Building CXX object compiler-rt/lib/sanitizer_common/CMakeFiles/RTSanitizerCommonSymbolizerNoHooks.powerpc64le.dir/sanitizer_symbolizer_report.cpp.o
1.049 [37/177/316] Building CXX object compiler-rt/lib/sanitizer_common/CMakeFiles/RTSanitizerCommonSymbolizer.powerpc64le.dir/sanitizer_symbolizer.cpp.o
1.050 [37/176/317] Building CXX object compiler-rt/lib/asan/CMakeFiles/RTAsan.powerpc64le.dir/asan_activation.cpp.o
1.051 [37/175/318] Building CXX object compiler-rt/lib/scudo/standalone/CMakeFiles/clang_rt.scudo_standalone-dynamic-powerpc64le.dir/string_utils.cpp.o
1.054 [37/174/319] Building CXX object compiler-rt/lib/sanitizer_common/CMakeFiles/RTSanitizerCommonLibc.powerpc64le.dir/sanitizer_common_libcdep.cpp.o
1.055 [37/173/320] Building CXX object compiler-rt/lib/sanitizer_common/CMakeFiles/RTSanitizerCommonNoHooks.powerpc64le.dir/sanitizer_procmaps_common.cpp.o
1.056 [37/172/321] Building CXX object compiler-rt/lib/sanitizer_common/CMakeFiles/RTSanitizerCommonSymbolizerNoHooks.powerpc64le.dir/sanitizer_symbolizer.cpp.o
1.057 [37/171/322] Building CXX object compiler-rt/lib/tsan/rtl/CMakeFiles/clang_rt.tsan-dynamic-powerpc64le.dir/tsan_interface_java.cpp.o
1.068 [37/170/323] Generating exported symbols for clang_rt.ubsan_minimal-powerpc64le
1.072 [37/169/324] Building CXX object compiler-rt/lib/sanitizer_common/CMakeFiles/RTSanitizerCommonNoHooks.powerpc64le.dir/sanitizer_flags.cpp.o
1.085 [37/168/325] Building CXX object compiler-rt/lib/sanitizer_common/CMakeFiles/RTSanitizerCommonLibcNoHooks.powerpc64le.dir/sanitizer_linux_libcdep.cpp.o
1.103 [37/167/326] Building CXX object compiler-rt/lib/sanitizer_common/CMakeFiles/RTSanitizerCommonNoTermination.powerpc64le.dir/sanitizer_platform_limits_posix.cpp.o
1.109 [37/166/327] Building CXX object compiler-rt/lib/tsan/rtl/CMakeFiles/clang_rt.tsan-dynamic-powerpc64le.dir/tsan_rtl_proc.cpp.o
1.109 [37/165/328] Building CXX object compiler-rt/lib/asan/CMakeFiles/RTAsan.powerpc64le.dir/asan_suppressions.cpp.o
1.114 [37/164/329] Building CXX object compiler-rt/lib/asan/CMakeFiles/RTAsan_dynamic.powerpc64le.dir/asan_memory_profile.cpp.o
1.119 [37/163/330] Building CXX object compiler-rt/lib/ubsan/CMakeFiles/RTUbsan.powerpc64le.dir/ubsan_diag.cpp.o
1.124 [37/162/331] Building CXX object compiler-rt/lib/sanitizer_common/CMakeFiles/RTSanitizerCommonNoTermination.powerpc64le.dir/sanitizer_suppressions.cpp.o
1.126 [37/161/332] Building C object compiler-rt/lib/profile/CMakeFiles/clang_rt.profile-powerpc64le.dir/InstrProfilingFile.c.o
1.127 [37/160/333] Building CXX object compiler-rt/lib/tsan/rtl/CMakeFiles/clang_rt.tsan-dynamic-powerpc64le.dir/tsan_symbolize.cpp.o
1.133 [37/159/334] Building CXX object compiler-rt/lib/sanitizer_common/CMakeFiles/RTSanitizerCommonLibcNoHooks.powerpc64le.dir/sanitizer_stoptheworld_linux_libcdep.cpp.o
1.137 [37/158/335] Building CXX object compiler-rt/lib/sanitizer_common/CMakeFiles/RTSanitizerCommonLibcNoHooks.powerpc64le.dir/sanitizer_common_libcdep.cpp.o
1.143 [37/157/336] Building CXX object compiler-rt/lib/sanitizer_common/CMakeFiles/RTSanitizerCommonLibcNoHooks.powerpc64le.dir/sanitizer_posix_libcdep.cpp.o
1.144 [37/156/337] Building CXX object compiler-rt/lib/sanitizer_common/CMakeFiles/RTSanitizerCommonSymbolizer.powerpc64le.dir/sanitizer_stacktrace_printer.cpp.o
1.157 [37/155/338] Building C object compiler-rt/lib/profile/CMakeFiles/clang_rt.profile-powerpc64le.dir/InstrProfilingValue.c.o
1.158 [37/154/339] Generating exported symbols for clang_rt.ubsan_standalone_cxx-powerpc64le
1.162 [37/153/340] Building CXX object compiler-rt/lib/sanitizer_common/CMakeFiles/RTSanitizerCommonSymbolizer.powerpc64le.dir/sanitizer_symbolizer_markup.cpp.o
1.163 [37/152/341] Building CXX object compiler-rt/lib/sanitizer_common/CMakeFiles/RTSanitizerCommonNoHooks.powerpc64le.dir/sanitizer_platform_limits_posix.cpp.o
1.164 [37/151/342] Building CXX object compiler-rt/lib/tsan/rtl/CMakeFiles/clang_rt.tsan-dynamic-powerpc64le.dir/tsan_interceptors_memintrinsics.cpp.o
1.164 [37/150/343] Building CXX object compiler-rt/lib/sanitizer_common/CMakeFiles/RTSanitizerCommon.powerpc64le.dir/sanitizer_suppressions.cpp.o
1.168 [37/149/344] Building CXX object compiler-rt/lib/sanitizer_common/CMakeFiles/RTSanitizerCommon.powerpc64le.dir/sanitizer_printf.cpp.o

```

</details>

https://github.com/llvm/llvm-project/pull/90959