[clang] [compiler-rt] [XRay] Add support for instrumentation of DSOs on x86_64 (PR #90959)

Fri Oct 11 02:31:29 PDT 2024

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `openmp-offload-amdgpu-runtime` running on `omp-vega20-0` while building `clang,compiler-rt` at step 5 "compile-openmp".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/30/builds/8054

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 5 (compile-openmp) failure: build (failure)
...
11.761 [1111/34/1037] Building CXX object compiler-rt/lib/xray/CMakeFiles/RTXrayBASIC.x86_64.dir/xray_basic_flags.cpp.o
11.768 [1110/34/1038] Building CXX object compiler-rt/lib/xray/CMakeFiles/RTXray.x86_64.dir/xray_init.cpp.o
/home/ompworker/bbot/openmp-offload-amdgpu-runtime/llvm.src/compiler-rt/lib/xray/xray_init.cpp:213:27: warning: comparison of integers of different signs: 'int32_t' (aka 'int') and 'size_t' (aka 'unsigned long') [-Wsign-compare]
  213 |   if (ObjId <= 0 || ObjId >= __xray_num_objects()) {
      |                     ~~~~~ ^  ~~~~~~~~~~~~~~~~~~~~
1 warning generated.
11.780 [1109/34/1039] Building CXX object compiler-rt/lib/nsan/CMakeFiles/RTNsan.x86_64.dir/nsan_allocator.cpp.o
11.781 [1108/34/1040] Building CXX object compiler-rt/lib/xray/CMakeFiles/RTXray.x86_64.dir/xray_log_interface.cpp.o
11.806 [1107/34/1041] Building CXX object compiler-rt/lib/fuzzer/CMakeFiles/RTfuzzer.i386.dir/FuzzerExtFunctionsDlsym.cpp.o
11.811 [1106/34/1042] Building CXX object compiler-rt/lib/xray/CMakeFiles/RTXray.x86_64.dir/xray_interface.cpp.o
FAILED: compiler-rt/lib/xray/CMakeFiles/RTXray.x86_64.dir/xray_interface.cpp.o 
/home/ompworker/bbot/openmp-offload-amdgpu-runtime/llvm.build/./bin/clang++ --target=x86_64-unknown-linux-gnu -DSANITIZER_COMMON_NO_REDEFINE_BUILTINS -DXRAY_HAS_EXCEPTIONS=1 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/ompworker/bbot/openmp-offload-amdgpu-runtime/llvm.src/compiler-rt/lib/xray/.. -I/home/ompworker/bbot/openmp-offload-amdgpu-runtime/llvm.src/compiler-rt/lib/xray/../../include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -Wall -Wno-unused-parameter -O3 -DNDEBUG -m64 -fPIC -fno-builtin -fno-exceptions -fomit-frame-pointer -funwind-tables -fno-stack-protector -fno-sanitize=safe-stack -fvisibility=hidden -fno-lto -Wthread-safety -Wthread-safety-reference -Wthread-safety-beta -O3 -gline-tables-only -Wno-gnu -Wno-variadic-macros -Wno-c99-extensions -ftrivial-auto-var-init=pattern -Wno-format -fno-rtti -std=c++17 -MD -MT compiler-rt/lib/xray/CMakeFiles/RTXray.x86_64.dir/xray_interface.cpp.o -MF compiler-rt/lib/xray/CMakeFiles/RTXray.x86_64.dir/xray_interface.cpp.o.d -o compiler-rt/lib/xray/CMakeFiles/RTXray.x86_64.dir/xray_interface.cpp.o -c /home/ompworker/bbot/openmp-offload-amdgpu-runtime/llvm.src/compiler-rt/lib/xray/xray_interface.cpp
/home/ompworker/bbot/openmp-offload-amdgpu-runtime/llvm.src/compiler-rt/lib/xray/xray_interface.cpp:16:10: fatal error: 'llvm/Support/ErrorHandling.h' file not found
   16 | #include "llvm/Support/ErrorHandling.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
11.811 [1106/33/1043] Linking CXX static library /home/ompworker/bbot/openmp-offload-amdgpu-runtime/llvm.build/lib/clang/20/lib/x86_64-unknown-linux-gnu/libclang_rt.nsan.a
11.835 [1106/32/1044] Building CXX object compiler-rt/lib/xray/CMakeFiles/RTXrayPROFILING.x86_64.dir/xray_profiling_flags.cpp.o
11.839 [1106/31/1045] Building ASM object compiler-rt/lib/xray/CMakeFiles/RTXrayDSO.x86_64.dir/xray_trampoline_x86_64.S.o
11.948 [1106/30/1046] Building CXX object compiler-rt/lib/xray/CMakeFiles/RTXrayDSO.x86_64.dir/xray_dso_init.cpp.o
11.950 [1106/29/1047] Building CXX object compiler-rt/lib/scudo/standalone/CMakeFiles/clang_rt.scudo_standalone_cxx-i386.dir/wrappers_cpp.cpp.o
11.952 [1106/28/1048] Building CXX object compiler-rt/lib/scudo/standalone/CMakeFiles/RTScudoStandaloneCxxWrappers.x86_64.dir/wrappers_cpp.cpp.o
12.031 [1106/27/1049] Building CXX object compiler-rt/lib/ctx_profile/CMakeFiles/clang_rt.ctx_profile-x86_64.dir/CtxInstrProfiling.cpp.o
12.111 [1106/26/1050] Building CXX object compiler-rt/lib/xray/CMakeFiles/RTXrayBASIC.x86_64.dir/xray_basic_logging.cpp.o
12.128 [1106/25/1051] Building CXX object compiler-rt/lib/scudo/standalone/CMakeFiles/clang_rt.scudo_standalone-dynamic-i386.dir/wrappers_cpp.cpp.o
12.131 [1106/24/1052] Building CXX object compiler-rt/lib/scudo/standalone/CMakeFiles/clang_rt.scudo_standalone_cxx-x86_64.dir/wrappers_cpp.cpp.o
12.325 [1106/23/1053] Building CXX object compiler-rt/lib/xray/CMakeFiles/RTXray.x86_64.dir/xray_buffer_queue.cpp.o
12.358 [1106/22/1054] Building CXX object compiler-rt/lib/scudo/standalone/CMakeFiles/RTScudoStandaloneCWrappers.i386.dir/wrappers_c.cpp.o
12.405 [1106/21/1055] Building CXX object compiler-rt/lib/fuzzer/CMakeFiles/RTfuzzer.i386.dir/FuzzerExtFunctionsWeak.cpp.o
12.440 [1106/20/1056] Building CXX object compiler-rt/lib/scudo/standalone/CMakeFiles/clang_rt.scudo_standalone-i386.dir/wrappers_c.cpp.o
12.484 [1106/19/1057] Building CXX object compiler-rt/lib/scudo/standalone/CMakeFiles/clang_rt.scudo_standalone-dynamic-i386.dir/wrappers_c.cpp.o
12.485 [1106/18/1058] Building CXX object compiler-rt/lib/xray/CMakeFiles/RTXray.x86_64.dir/xray_utils.cpp.o
12.522 [1106/17/1059] Building CXX object compiler-rt/lib/scudo/standalone/CMakeFiles/clang_rt.scudo_standalone-dynamic-x86_64.dir/wrappers_cpp.cpp.o
12.535 [1106/16/1060] Building CXX object compiler-rt/lib/xray/CMakeFiles/RTXray.x86_64.dir/xray_x86_64.cpp.o
12.581 [1106/15/1061] Building CXX object compiler-rt/lib/scudo/standalone/CMakeFiles/RTScudoStandaloneCWrappers.x86_64.dir/wrappers_c.cpp.o
12.711 [1106/14/1062] Building CXX object compiler-rt/lib/xray/CMakeFiles/RTXrayPROFILING.x86_64.dir/xray_profiling.cpp.o
12.720 [1106/13/1063] Building CXX object compiler-rt/lib/scudo/standalone/CMakeFiles/clang_rt.scudo_standalone-x86_64.dir/wrappers_c.cpp.o
12.798 [1106/12/1064] Building CXX object compiler-rt/lib/scudo/standalone/CMakeFiles/clang_rt.scudo_standalone-dynamic-x86_64.dir/wrappers_c.cpp.o
12.995 [1106/11/1065] Building CXX object compiler-rt/lib/xray/CMakeFiles/RTXrayPROFILING.x86_64.dir/xray_profile_collector.cpp.o
13.104 [1106/10/1066] Building CXX object compiler-rt/lib/xray/CMakeFiles/RTXrayFDR.x86_64.dir/xray_fdr_logging.cpp.o
13.260 [1106/9/1067] Building CXX object compiler-rt/lib/fuzzer/CMakeFiles/RTfuzzer.i386.dir/FuzzerCrossOver.cpp.o
15.418 [1106/8/1068] Building CXX object compiler-rt/lib/fuzzer/CMakeFiles/RTfuzzer.i386.dir/FuzzerDriver.cpp.o
17.865 [1106/7/1069] Building CXX object compiler-rt/lib/msan/CMakeFiles/clang_rt.msan-x86_64.dir/msan_interceptors.cpp.o
18.068 [1106/6/1070] Building CXX object compiler-rt/lib/tsan/rtl/CMakeFiles/clang_rt.tsan-x86_64.dir/tsan_interceptors_posix.cpp.o
18.462 [1106/5/1071] Building CXX object compiler-rt/lib/tsan/rtl/CMakeFiles/clang_rt.tsan-dynamic-x86_64.dir/tsan_interceptors_posix.cpp.o
20.242 [1106/4/1072] Building CXX object compiler-rt/lib/asan/CMakeFiles/RTAsan_dynamic.i386.dir/asan_interceptors.cpp.o
20.508 [1106/3/1073] Building CXX object compiler-rt/lib/asan/CMakeFiles/RTAsan_dynamic.x86_64.dir/asan_interceptors.cpp.o
20.709 [1106/2/1074] Building CXX object compiler-rt/lib/asan/CMakeFiles/RTAsan.i386.dir/asan_interceptors.cpp.o
21.052 [1106/1/1075] Building CXX object compiler-rt/lib/asan/CMakeFiles/RTAsan.x86_64.dir/asan_interceptors.cpp.o

```

</details>

https://github.com/llvm/llvm-project/pull/90959