[clang] [llvm] Apply alignment / size in linker rather than IR (PR #111918)

via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 10 16:09:40 PDT 2024


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff 923566a67de39a00eb6fc5cabbad307a72aa338e 3a962270521aa7b48b64e5ac5fa0edb900990023 --extensions h,cpp -- clang/lib/CodeGen/SanitizerMetadata.cpp llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp llvm/lib/Target/AArch64/AArch64.h llvm/lib/Target/AArch64/AArch64TargetMachine.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/clang/lib/CodeGen/SanitizerMetadata.cpp b/clang/lib/CodeGen/SanitizerMetadata.cpp
index 784d906164..95e3f8a01f 100644
--- a/clang/lib/CodeGen/SanitizerMetadata.cpp
+++ b/clang/lib/CodeGen/SanitizerMetadata.cpp
@@ -92,8 +92,8 @@ void SanitizerMetadata::reportGlobal(llvm::GlobalVariable *GV,
       FsanitizeArgument.Mask & SanitizerKind::HWAddress, GV, Loc, Ty);
 
   if (shouldTagGlobal(*GV)) {
-    Meta.Memtag |=
-        static_cast<bool>(FsanitizeArgument.Mask & SanitizerKind::MemtagGlobals);
+    Meta.Memtag |= static_cast<bool>(FsanitizeArgument.Mask &
+                                     SanitizerKind::MemtagGlobals);
     Meta.Memtag &= !NoSanitizeAttrSet.hasOneOf(SanitizerKind::MemTag);
     Meta.Memtag &= !CGM.isInNoSanitizeList(
         FsanitizeArgument.Mask & SanitizerKind::MemTag, GV, Loc, Ty);
diff --git a/llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp b/llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
index 6a2817f417..aade8e1368 100644
--- a/llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
+++ b/llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
@@ -764,7 +764,8 @@ void AsmPrinter::emitGlobalVariable(const GlobalVariable *GV) {
 
   const DataLayout &DL = GV->getDataLayout();
   uint64_t Size = DL.getTypeAllocSize(GV->getValueType());
-  if (GV->isTagged()) Size = alignTo(Size, 16);
+  if (GV->isTagged())
+    Size = alignTo(Size, 16);
 
   // If the alignment is specified, we *must* obey it.  Overaligning a global
   // with a specified alignment is a prompt way to break globals emitted to

``````````

</details>


https://github.com/llvm/llvm-project/pull/111918


More information about the cfe-commits mailing list