[clang] [llvm] [SystemZ][z/OS] Add new openFileForReadBinary function, and pass IsText parameter to getBufferForFile (PR #111723)
kadir çetinkaya via cfe-commits
cfe-commits at lists.llvm.org
Thu Oct 10 07:31:37 PDT 2024
================
@@ -292,21 +292,21 @@ class FileManager : public RefCountedBase<FileManager> {
/// MemoryBuffer if successful, otherwise returning null.
llvm::ErrorOr<std::unique_ptr<llvm::MemoryBuffer>>
getBufferForFile(FileEntryRef Entry, bool isVolatile = false,
- bool RequiresNullTerminator = true,
+ bool RequiresNullTerminator = true, bool IsText = true,
----------------
kadircet wrote:
can you add some comments explaining what `IsText` is about and when it should be set to `false`?
also can you make it the last parameter ?
https://github.com/llvm/llvm-project/pull/111723
More information about the cfe-commits
mailing list