[clang] [clang] assume_aligned incorrectly diagnoses a dependent return type (PR #111573)

Erich Keane via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 9 09:30:10 PDT 2024


================
@@ -4453,9 +4453,9 @@ class Sema final : public SemaBase {
                                       SourceLocation *ArgLocation = nullptr);
 
   /// Determine if type T is a valid subject for a nonnull and similar
-  /// attributes. By default, we look through references (the behavior used by
-  /// nonnull), but if the second parameter is true, then we treat a reference
-  /// type as valid.
+  /// attributes. We skip dependence By default, we look through references
----------------
erichkeane wrote:

again, we're not skipping dependence by default, we're ALWAYS skipping dependence.  We skip references (presumably by default).  I think the dependence behavior just needs its own sentence here.

https://github.com/llvm/llvm-project/pull/111573


More information about the cfe-commits mailing list