[clang] [clang][python] Don't add check-clang-python to check-all if cross-compiling (PR #111657)
Aaron Ballman via cfe-commits
cfe-commits at lists.llvm.org
Wed Oct 9 06:04:51 PDT 2024
================
@@ -47,6 +47,14 @@ if(${LLVM_NATIVE_ARCH} MATCHES "^(AArch64|Hexagon|Sparc|SystemZ)$")
set(RUN_PYTHON_TESTS FALSE)
endif()
+# Tests will fail if cross-compiling for a different target, as tests will try
+# to use the host Python3_EXECUTABLE and make FFI calls to functions in target
+# libraries.
+if(CMAKE_CROSS_COMPILING)
----------------
AaronBallman wrote:
If I understand correctly, I think we probably do want a FIXME for clarity because we'd ultimately like the python tests to work in a cross-compile situation because I don't think there should be a distinction between running the C binding tests and the Python binding tests. Potentially we might be able to do this by hooking them in to the lit-orchestrated tests and using `LIT_ARGS` the same as the Clang tests?
Regardless, nothing has to be done for now beyond adding a FIXME comment; and if we decide the complexity is too great when digging into doing that effort, we can always walk back the comment.
https://github.com/llvm/llvm-project/pull/111657
More information about the cfe-commits
mailing list