[clang] [clang][python] Add CLANG_DISABLE_RUN_PYTHON_TESTS CMake option to disable clang python bindings tests (PR #111367)

Vlad Serebrennikov via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 9 00:40:23 PDT 2024


Endilll wrote:

> > > We already have hard-coded logic to disable adding these tests to the `check-all` target in various cases.
> > 
> > 
> > Why do you have to do that?
> 
> I've never worked with the clang python bindings before, but you can basically see the reasoning in https://github.com/llvm/llvm-project/blob/bf7022f71a95313e8ebdd34e5ea7cb7bca90a24d/clang/bindings/python/tests/CMakeLists.txt - there are various targets and configurations where they are expected or known to fail.

Sorry, I'm asking for the use case for the particular CMake knob you're adding. If there are more platforms that those tests are not working on, we should simply expand the pre-existing list https://github.com/llvm/llvm-project/blob/e2dc50c92987e6886b1b1641ebdbe9cc53bae192/clang/bindings/python/tests/CMakeLists.txt#L46

Or, better, disable tests individually based on the triple, like we do elsewhere.

https://github.com/llvm/llvm-project/pull/111367


More information about the cfe-commits mailing list