[clang-tools-extra] [clangd] Add inlay hints for default function arguments (PR #95712)

Nathan Ridge via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 8 23:56:39 PDT 2024


================
@@ -709,7 +738,8 @@ class InlayHintVisitor : public RecursiveASTVisitor<InlayHintVisitor> {
 private:
   using NameVec = SmallVector<StringRef, 8>;
 
-  void processCall(Callee Callee, llvm::ArrayRef<const Expr *> Args) {
+  void processCall(Callee Callee, SourceRange RParenOrBraceRange,
----------------
HighCommander4 wrote:

I think it would be clearer for the `SourceRange RParenOrBraceRange` parameter to be `SourceLocation RParenOrBraceLoc` instead.

Both call sites in fact pass a `SourceLocation`, which currently gets implicitly converted to a singleton range.

I'd rather we do that conversion inside the function's implementation, and make it explicit with `SourceRange{RParenOrBraceLoc}`.

https://github.com/llvm/llvm-project/pull/95712


More information about the cfe-commits mailing list