[clang] [clang-tools-extra] RFC: [clang-tidy] [analyzer] Move nondeterministic pointer usage check to tidy (PR #110471)

[Julian Schmidt via cfe-commits]

https://github.com/5chmidti requested changes to this pull request.

I've added comments for cleaning up the implementation, and also questions/suggestions for future enhancements that are prefixed with `~:`. I went with basically-NFC-cleanups, instead of improvements, in order to have this PR stay a `moving to clang-tidy` PR but improving the implementation quality.
Functionality-wise, this looks fine, but with various points that should be addressed to enhance the check after this lands.

https://github.com/llvm/llvm-project/pull/110471