[clang] [llvm] Adding splitdouble HLSL function (PR #109331)

Chris B via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 8 07:23:23 PDT 2024


================
@@ -4681,6 +4681,11 @@ void CallArg::copyInto(CodeGenFunction &CGF, Address Addr) const {
   IsUsed = true;
 }
 
+void CodeGenFunction::EmitWritebacks(CodeGenFunction &CGF,
+                                     const CallArgList &args) {
+  emitWritebacks(CGF, args);
----------------
llvm-beanz wrote:

 If the C++ ABI's arguments are destroyed left-to-right the writebacks need to be reversed before this is called. Something like:
 
 ```suggestion
  if (getTarget().getCXXABI().areArgsDestroyedLeftToRightInCallee())
    Args.reverseWritebacks();
  emitWritebacks(CGF, args);
```

https://github.com/llvm/llvm-project/pull/109331


More information about the cfe-commits mailing list