[clang] [llvm] [clang][llvm][SPIR-V] Explicitly encode native integer widths for SPIR-V (PR #110695)

Matt Arsenault via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 7 10:44:27 PDT 2024


================
@@ -1,12 +1,14 @@
 ; This test aims to check ability to support "Arithmetic with Overflow" intrinsics
 ; in the special case when those intrinsics are being generated by the CodeGenPrepare;
-; pass during translations with optimization (note -O3 in llc arguments).
+; pass during translations with optimization (note -disable-lsr, to inhibit
+; strength reduction pre-empting with a more preferable match for this pattern
+; in llc arguments).
 
-; RUN: llc -O3 -mtriple=spirv32-unknown-unknown %s -o - | FileCheck %s
-; RUN: %if spirv-tools %{ llc -O3 -mtriple=spirv32-unknown-unknown %s -o - -filetype=obj | spirv-val %}
+; RUN: llc -O3 -disable-lsr -mtriple=spirv32-unknown-unknown %s -o - | FileCheck %s
----------------
arsenm wrote:

 If the intent is to specifically check codegenprepare, should have an IR->IR test in test/Transforms/CodeGenPrepare.

I don't know whether the -disable-lsr output is the best or not, but based on the name of the test I would assume this would try to document the actual result, not with the special flag. 

Also this test shouldn't have been using -O3 (it barely does anything and -O2 is the default) 


https://github.com/llvm/llvm-project/pull/110695


More information about the cfe-commits mailing list