[clang] [clang] Code owners -> Maintainers transition (PR #108997)

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 7 07:47:20 PDT 2024


https://github.com/AaronBallman updated https://github.com/llvm/llvm-project/pull/108997

>From 10f74046b87f67a6efba1ee30806e73eea14007e Mon Sep 17 00:00:00 2001
From: Aaron Ballman <aaron at aaronballman.com>
Date: Mon, 16 Sep 2024 08:59:45 -0400
Subject: [PATCH 1/2] [clang] Code owners -> Maintainers transition

This is the initial transition from using "code owners" to using
"maintainers". It presumes that every current code owner is willing to
continue as a maintainer.
---
 clang/{CodeOwners.rst => Maintainers.rst} | 32 +++++++++++------------
 clang/docs/CMakeLists.txt                 |  2 +-
 clang/docs/CodeOwners.rst                 |  1 -
 clang/docs/Maintainers.rst                |  1 +
 clang/docs/index.rst                      |  2 +-
 5 files changed, 19 insertions(+), 19 deletions(-)
 rename clang/{CodeOwners.rst => Maintainers.rst} (92%)
 delete mode 100644 clang/docs/CodeOwners.rst
 create mode 100644 clang/docs/Maintainers.rst

diff --git a/clang/CodeOwners.rst b/clang/Maintainers.rst
similarity index 92%
rename from clang/CodeOwners.rst
rename to clang/Maintainers.rst
index 2ae04c129eb765..766161dbbfc614 100644
--- a/clang/CodeOwners.rst
+++ b/clang/Maintainers.rst
@@ -1,30 +1,30 @@
 =================
-Clang Code Owners
+Clang Maintainers
 =================
 
 This file is a list of the
-`code owners <https://llvm.org/docs/DeveloperPolicy.html#code-owners>`_ for
+`maintainers <https://llvm.org/docs/DeveloperPolicy.html#maintainers>`_ for
 Clang.
 
 .. contents::
    :depth: 2
    :local:
 
-Current Code Owners
-===================
-The following people are the active code owners for the project. Please reach
+Active Maintainers
+==================
+The following people are the active maintainers for the project. Please reach
 out to them for code reviews, questions about their area of expertise, or other
 assistance.
 
-All parts of Clang not covered by someone else
-----------------------------------------------
+Lead Maintainer
+---------------
 | Aaron Ballman
 | aaron\@aaronballman.com (email), aaron.ballman (Phabricator), AaronBallman (GitHub), AaronBallman (Discourse), aaronballman (Discord), AaronBallman (IRC)
 
 
 Contained Components
 --------------------
-These code owners are responsible for particular high-level components within
+These maintainers are responsible for particular high-level components within
 Clang that are typically contained to one area of the compiler.
 
 AST matchers
@@ -125,7 +125,7 @@ Driver parts not covered by someone else
 
 Tools
 -----
-These code owners are responsible for user-facing tools under the Clang
+These maintainers are responsible for user-facing tools under the Clang
 umbrella or components used to support such tools.
 
 Tooling library
@@ -255,19 +255,19 @@ SYCL conformance
 | alexey.bader\@intel.com (email), bader (Phabricator), bader (GitHub)
 
 
-Former Code Owners
-==================
-The following people have graciously spent time performing code ownership
+Inactive Maintainers
+====================
+The following people have graciously spent time performing maintainership
 responsibilities but are no longer active in that role. Thank you for all your
 help with the success of the project!
 
-Emeritus owners
----------------
+Emeritus Lead Maintainers
+-------------------------
 | Doug Gregor (dgregor\@apple.com)
 | Richard Smith (richard\@metafoo.co.uk)
 
 
-Former component owners
------------------------
+Inactive component maintainers
+------------------------------
 | Chandler Carruth (chandlerc\@gmail.com, chandlerc\@google.com) -- CMake, library layering
 | Devin Coughlin (dcoughlin\@apple.com) -- Clang static analyzer
diff --git a/clang/docs/CMakeLists.txt b/clang/docs/CMakeLists.txt
index 51e9db29f887f3..4fecc007f59954 100644
--- a/clang/docs/CMakeLists.txt
+++ b/clang/docs/CMakeLists.txt
@@ -117,7 +117,7 @@ if (LLVM_ENABLE_SPHINX)
       "${CMAKE_CURRENT_SOURCE_DIR}" "${CMAKE_CURRENT_BINARY_DIR}"
 
       COMMAND "${CMAKE_COMMAND}" -E copy_if_different
-      "${CMAKE_CURRENT_SOURCE_DIR}/../CodeOwners.rst"
+      "${CMAKE_CURRENT_SOURCE_DIR}/../Maintainers.rst"
       "${CMAKE_CURRENT_BINARY_DIR}"
     )
 
diff --git a/clang/docs/CodeOwners.rst b/clang/docs/CodeOwners.rst
deleted file mode 100644
index 48128fbc5d909b..00000000000000
--- a/clang/docs/CodeOwners.rst
+++ /dev/null
@@ -1 +0,0 @@
-.. include:: ../CodeOwners.rst
diff --git a/clang/docs/Maintainers.rst b/clang/docs/Maintainers.rst
new file mode 100644
index 00000000000000..7e69c1165d2f54
--- /dev/null
+++ b/clang/docs/Maintainers.rst
@@ -0,0 +1 @@
+.. include:: ../Maintainers.rst
diff --git a/clang/docs/index.rst b/clang/docs/index.rst
index 4a497f4d9bcc3c..f4fdc93290a0d9 100644
--- a/clang/docs/index.rst
+++ b/clang/docs/index.rst
@@ -104,7 +104,7 @@ Design Documents
 .. toctree::
    :maxdepth: 1
 
-   CodeOwners
+   Maintainers
    InternalsManual
    DriverInternals
    Multilib

>From f32840fee0c577138151991bfaca1814f1273329 Mon Sep 17 00:00:00 2001
From: Aaron Ballman <aaron at aaronballman.com>
Date: Fri, 20 Sep 2024 08:27:45 -0400
Subject: [PATCH 2/2] Updated inactive maintainers list

I've not heard back from Manuel or Michael from the ping on the PR, so
I've moved them to the inactive maintainers list and volunteered myself
to take over AST matchers (I've already been doing those reviews for
ages anyway). However, I also just reached out to both of them via
email, so I'm waiting for them to have a chance to respond there, in
case they missed the ping on the PR.
---
 clang/Maintainers.rst | 14 ++++----------
 1 file changed, 4 insertions(+), 10 deletions(-)

diff --git a/clang/Maintainers.rst b/clang/Maintainers.rst
index 766161dbbfc614..3d050e69c47165 100644
--- a/clang/Maintainers.rst
+++ b/clang/Maintainers.rst
@@ -29,8 +29,8 @@ Clang that are typically contained to one area of the compiler.
 
 AST matchers
 ~~~~~~~~~~~~
-| Manuel Klimek
-| klimek\@google.com (email), klimek (Phabricator), r4nt (GitHub)
+| Aaron Ballman
+| aaron\@aaronballman.com (email), aaron.ballman (Phabricator), AaronBallman (GitHub), AaronBallman (Discourse), aaronballman (Discord), AaronBallman (IRC)
 
 
 Clang LLVM IR generation
@@ -68,9 +68,6 @@ Modules & serialization
 | Chuanqi Xu
 | yedeng.yd\@linux.alibaba.com (email), ChuanqiXu (Phabricator), ChuanqiXu9 (GitHub)
 
-| Michael Spencer
-| bigcheesegs\@gmail.com (email), Bigcheese (Phabricator), Bigcheese (GitHub)
-
 
 Templates
 ~~~~~~~~~
@@ -128,11 +125,6 @@ Tools
 These maintainers are responsible for user-facing tools under the Clang
 umbrella or components used to support such tools.
 
-Tooling library
-~~~~~~~~~~~~~~~
-| Manuel Klimek
-| klimek\@google.com (email), klimek (Phabricator), r4nt (GitHub)
-
 
 clang-format
 ~~~~~~~~~~~~
@@ -271,3 +263,5 @@ Inactive component maintainers
 ------------------------------
 | Chandler Carruth (chandlerc\@gmail.com, chandlerc\@google.com) -- CMake, library layering
 | Devin Coughlin (dcoughlin\@apple.com) -- Clang static analyzer
+| Manuel Klimek (klimek\@google.com (email), klimek (Phabricator), r4nt (GitHub)) -- Tooling, AST matchers
+| Michael Spencer (bigcheesegs\@gmail.com (email), Bigcheese (Phabricator), Bigcheese (GitHub)) -- Modules & serialization



More information about the cfe-commits mailing list