[clang] [Sema] Avoid repeated hash lookups (NFC) (PR #111090)
via cfe-commits
cfe-commits at lists.llvm.org
Thu Oct 3 20:00:16 PDT 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-clang
Author: Kazu Hirata (kazutakahirata)
<details>
<summary>Changes</summary>
---
Full diff: https://github.com/llvm/llvm-project/pull/111090.diff
1 Files Affected:
- (modified) clang/lib/Sema/SemaLambda.cpp (+3-3)
``````````diff
diff --git a/clang/lib/Sema/SemaLambda.cpp b/clang/lib/Sema/SemaLambda.cpp
index c2b35856111f3b..aeb20299b714a3 100644
--- a/clang/lib/Sema/SemaLambda.cpp
+++ b/clang/lib/Sema/SemaLambda.cpp
@@ -423,11 +423,11 @@ bool Sema::DiagnoseInvalidExplicitObjectParameterInLambda(
// is an empty cast path for the method stored in the context (signalling that
// we've already diagnosed it) and then just not building the call, but that
// doesn't really seem any simpler than diagnosing it at the call site...
- if (auto It = Context.LambdaCastPaths.find(Method);
- It != Context.LambdaCastPaths.end())
+ auto [It, Inserted] = Context.LambdaCastPaths.try_emplace(Method);
+ if (!Inserted)
return It->second.empty();
- CXXCastPath &Path = Context.LambdaCastPaths[Method];
+ CXXCastPath &Path = It->second;
CXXBasePaths Paths(/*FindAmbiguities=*/true, /*RecordPaths=*/true,
/*DetectVirtual=*/false);
if (!IsDerivedFrom(RD->getLocation(), ExplicitObjectParameterType, LambdaType,
``````````
</details>
https://github.com/llvm/llvm-project/pull/111090
More information about the cfe-commits
mailing list