[clang] [Clang][HIP] Warn when __AMDGCN_WAVEFRONT_SIZE is used in host code without relying on target-dependent overload resolution (PR #109663)

[Alex Voicu via cfe-commits]

AlexVlx wrote:

> > I don't think we should rely on these on the host at all, the addition was a design mistake initially, we probably should not double down on it.
> 
> I agree with it in principle. However, removing things that already exist should be done with consideration for the existing users. This particular macro may happen to be working well enough for some users and we may want to consider whether we can transition from here to the point where these macros no longer exist on the host, without causing much disruption, or, at least, giving the affected users enough of heads-up time to deal with it.

Sure, I'm not arguing that we should just delete these outright and have folks deal with the aftermath. I'm just biased towards deprecation + actual removal because I think this existing is just going to become increasingly problematic as we go forward.



https://github.com/llvm/llvm-project/pull/109663