[clang] [analyzer] Suppress out of bounds reports after weak loop assumptions (PR #109804)

[Donát Nagy via cfe-commits]

NagyDonat wrote:

@isuckatcs If I am not mistaken, I reacted to every comment in your first review.

I'm sorry for the salty initial reactions -- after thinking about this topic for months, I ended up feeling that everything is _so obvious_, while in fact it's a really complicated topic and perhaps my original explanations weren't clear enough.

I understand your point of view that it would be _nice_ if the programmers marked their knowledge with assertions (and we could reason based on the lack of assertions), and e.g. half a year ago I might've agreed with you, but I don't think that it's the way forward. This is an application where the user is always right and we must avoid producing annoying/unwanted reports even if they are technically correct or they would become helpful after some additional work performed by the user.

https://github.com/llvm/llvm-project/pull/109804