[clang] [clang-tools-extra] [lldb] [llvm] Propagate IsText parameter to openFileForRead function (PR #110661)

[kadir çetinkaya via cfe-commits]

https://github.com/kadircet requested changes to this pull request.

sorry this is same as https://github.com/llvm/llvm-project/pull/107906 (with a bigger impact radius, as you're also changing getBufferForFile) and doesn't address any of the issues mention about explaining the semantics of `IsText` or justification for changing the core VFS interfaces, for an operation that's can solely be performed on physical fileystem.

@perry-ca raised some concerns in https://github.com/llvm/llvm-project/pull/109664 about this functionality requiring some context awareness, I don't think any of those is addressed by this patch either. Pretty much all of the callers apart from ASTReader is just using `IsText = true`.

https://github.com/llvm/llvm-project/pull/110661