[clang] [Clang][CodeGen] Emit load of GEP after EmitMemberExpr (PR #110487)

[Eli Friedman via cfe-commits]

https://github.com/efriedma-quic commented:

This is sort of the same comment I've made on other related patches... but I think the fundamental issue here is that StructAccessBase is skipping over CK_LValueToRValue casts.  Once you jump over such a cast, you're looking at expressions which are at a different level of indirection from the member access you care about.

If StructAccessBase just returns the cast itself, instead of trying to understand the value that's getting loaded, you shouldn't need a special case for MemberExpr.

https://github.com/llvm/llvm-project/pull/110487