[clang] [clang-tools-extra] [clangd] [AST] Handle uninitialized type constraints (PR #110496)

Younan Zhang via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 30 06:49:13 PDT 2024


https://github.com/zyn0217 commented:

Thanks again for analyzing & working on this issue.

Some suggestions regarding the test:

1. As this is more of a clang issue (the offending code belongs to the serialization part of clang), so it is more appropriate to write a clang test instead of a clangd test.

2. We don't usually write lit tests but rather unit tests (specifically, tests under the `clangd/unittests` directory) for clangd.

The other part LG in general, but I'd like to hear input from folks who are more familiar with the serialization.

https://github.com/llvm/llvm-project/pull/110496


More information about the cfe-commits mailing list