[clang] [analyzer] Suppress out of bounds reports after weak loop assumptions (PR #109804)

[Balazs Benics via cfe-commits]

=?utf-8?q?Donát?= Nagy <donat.nagy at ericsson.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/109804 at github.com>


================
@@ -2808,27 +2825,63 @@ void ExprEngine::processBranch(const Stmt *Condition,
       std::tie(StTrue, StFalse) = *KnownCondValueAssumption;
     else {
       assert(!isa<ObjCForCollectionStmt>(Condition));
+      // TODO: instead of this shortcut perhaps it would be better to "rejoin"
+      // the common execution path with
+      // StTrue = StFalse = PrevState;
----------------
steakhal wrote:

I'd rather drop this, as it's not clear when could we achieve this. Unactionable comments are not useful long term. I'd expect contributors being able to push for a change like this be able to pinpoint this location in source code without any external help. For anyone else, it's just noise and confusing.

https://github.com/llvm/llvm-project/pull/109804