[clang] [llvm] Deprecate the `-fbasic-block-sections=labels` option. (PR #107494)

Fri Sep 27 00:50:30 PDT 2024

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `llvm-x86_64-debian-dylib` running on `gribozavr4` while building `clang,llvm` at step 5 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/60/builds/8662

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 5 (build-unified-tree) failure: build (failure)
...
717.398 [1033/96/5846] Building CXX object tools/clang/tools/extra/clangd/CMakeFiles/obj.clangDaemon.dir/index/CanonicalIncludes.cpp.o
717.413 [1032/96/5847] Building CXX object tools/clang/tools/extra/clang-move/CMakeFiles/obj.clangMove.dir/Move.cpp.o
717.451 [1031/96/5848] Building CXX object tools/clang/tools/extra/clangd/CMakeFiles/obj.clangDaemon.dir/index/Index.cpp.o
718.713 [1030/96/5849] Building CXX object tools/clang/tools/extra/clangd/CMakeFiles/obj.clangDaemon.dir/CodeCompletionStrings.cpp.o
719.597 [1029/96/5850] Building CXX object tools/opt/CMakeFiles/LLVMOptDriver.dir/NewPMDriver.cpp.o
719.631 [1028/96/5851] Building CXX object tools/clang/tools/extra/clangd/CMakeFiles/obj.clangDaemon.dir/index/Merge.cpp.o
719.667 [1027/96/5852] Building CXX object tools/clang/tools/extra/clangd/CMakeFiles/obj.clangDaemon.dir/index/ProjectAware.cpp.o
719.706 [1026/96/5853] Building CXX object tools/clang/tools/extra/clangd/CMakeFiles/obj.clangDaemon.dir/index/Ref.cpp.o
719.749 [1025/96/5854] Building CXX object tools/clang/tools/extra/clangd/CMakeFiles/obj.clangDaemon.dir/index/Relation.cpp.o
723.167 [1024/96/5855] Building CXX object tools/lld/ELF/CMakeFiles/lldELF.dir/LTO.cpp.o
FAILED: tools/lld/ELF/CMakeFiles/lldELF.dir/LTO.cpp.o 
CCACHE_CPP2=yes CCACHE_HASHDIR=yes /usr/bin/ccache /usr/bin/clang++ -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/b/1/llvm-x86_64-debian-dylib/build/tools/lld/ELF -I/b/1/llvm-x86_64-debian-dylib/llvm-project/lld/ELF -I/b/1/llvm-x86_64-debian-dylib/llvm-project/lld/include -I/b/1/llvm-x86_64-debian-dylib/build/tools/lld/include -I/b/1/llvm-x86_64-debian-dylib/build/include -I/b/1/llvm-x86_64-debian-dylib/llvm-project/llvm/include -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -std=c++17 -MD -MT tools/lld/ELF/CMakeFiles/lldELF.dir/LTO.cpp.o -MF tools/lld/ELF/CMakeFiles/lldELF.dir/LTO.cpp.o.d -o tools/lld/ELF/CMakeFiles/lldELF.dir/LTO.cpp.o -c /b/1/llvm-x86_64-debian-dylib/llvm-project/lld/ELF/LTO.cpp
/b/1/llvm-x86_64-debian-dylib/llvm-project/lld/ELF/LTO.cpp:74:49: error: no member named 'Labels' in 'llvm::BasicBlockSection'
      c.Options.BBSections = BasicBlockSection::Labels;
                             ~~~~~~~~~~~~~~~~~~~^
1 error generated.
723.419 [1024/95/5856] Building CXX object tools/clang/tools/extra/clang-tidy/utils/CMakeFiles/obj.clangTidyUtils.dir/RenamerClangTidyCheck.cpp.o
723.573 [1024/94/5857] Building CXX object tools/clang/tools/libclang/CMakeFiles/libclang.dir/CIndex.cpp.o
723.772 [1024/93/5858] Building CXX object tools/lld/wasm/CMakeFiles/lldWasm.dir/MarkLive.cpp.o
724.156 [1024/92/5859] Building CXX object tools/lld/wasm/CMakeFiles/lldWasm.dir/InputChunks.cpp.o
724.291 [1024/91/5860] Building CXX object tools/clang/tools/extra/include-cleaner/lib/CMakeFiles/obj.clangIncludeCleaner.dir/WalkAST.cpp.o
724.308 [1024/90/5861] Building CXX object tools/lld/wasm/CMakeFiles/lldWasm.dir/OutputSegment.cpp.o
724.952 [1024/89/5862] Building CXX object tools/lld/wasm/CMakeFiles/lldWasm.dir/OutputSections.cpp.o
725.097 [1024/88/5863] Building CXX object tools/lld/wasm/CMakeFiles/lldWasm.dir/Symbols.cpp.o
725.729 [1024/87/5864] Building CXX object tools/lld/wasm/CMakeFiles/lldWasm.dir/Relocations.cpp.o
726.593 [1024/86/5865] Building CXX object tools/lld/wasm/CMakeFiles/lldWasm.dir/MapFile.cpp.o
726.805 [1024/85/5866] Building CXX object tools/lld/wasm/CMakeFiles/lldWasm.dir/LTO.cpp.o
726.837 [1024/84/5867] Building CXX object tools/lld/COFF/CMakeFiles/lldCOFF.dir/LTO.cpp.o
727.671 [1024/83/5868] Building CXX object tools/clang/tools/extra/clangd/CMakeFiles/obj.clangDaemon.dir/SystemIncludeExtractor.cpp.o
728.436 [1024/82/5869] Building CXX object tools/clang/tools/extra/clang-tidy/misc/CMakeFiles/obj.clangTidyMiscModule.dir/UnusedAliasDeclsCheck.cpp.o
728.620 [1024/81/5870] Building CXX object tools/lld/MachO/CMakeFiles/lldMachO.dir/LTO.cpp.o
729.090 [1024/80/5871] Building CXX object tools/clang/tools/extra/clang-tidy/misc/CMakeFiles/obj.clangTidyMiscModule.dir/CoroutineHostileRAIICheck.cpp.o
729.097 [1024/79/5872] Building CXX object tools/clang/tools/extra/clang-tidy/misc/CMakeFiles/obj.clangTidyMiscModule.dir/ThrowByValueCatchByReferenceCheck.cpp.o
729.409 [1024/78/5873] Building CXX object tools/lld/COFF/CMakeFiles/lldCOFF.dir/SymbolTable.cpp.o
729.633 [1024/77/5874] Building CXX object tools/clang/tools/extra/clangd/CMakeFiles/obj.clangDaemon.dir/Compiler.cpp.o
729.871 [1024/76/5875] Building CXX object tools/clang/tools/extra/clang-tidy/misc/CMakeFiles/obj.clangTidyMiscModule.dir/NonCopyableObjects.cpp.o
730.061 [1024/75/5876] Building CXX object tools/clang/tools/extra/clang-tidy/misc/CMakeFiles/obj.clangTidyMiscModule.dir/UseAnonymousNamespaceCheck.cpp.o
730.469 [1024/74/5877] Building CXX object tools/clang/tools/extra/clang-tidy/misc/CMakeFiles/obj.clangTidyMiscModule.dir/UniqueptrResetReleaseCheck.cpp.o
730.586 [1024/73/5878] Building CXX object tools/clang/tools/extra/clang-tidy/misc/CMakeFiles/obj.clangTidyMiscModule.dir/NonPrivateMemberVariablesInClassesCheck.cpp.o
731.043 [1024/72/5879] Building CXX object tools/lld/wasm/CMakeFiles/lldWasm.dir/SymbolTable.cpp.o
731.063 [1024/71/5880] Building CXX object tools/lld/wasm/CMakeFiles/lldWasm.dir/InputFiles.cpp.o
731.090 [1024/70/5881] Building CXX object tools/clang/tools/extra/clang-tidy/misc/CMakeFiles/obj.clangTidyMiscModule.dir/MisplacedConstCheck.cpp.o
731.146 [1024/69/5882] Building CXX object tools/clang/tools/extra/clang-tidy/misc/CMakeFiles/obj.clangTidyMiscModule.dir/DefinitionsInHeadersCheck.cpp.o
731.169 [1024/68/5883] Building CXX object tools/lld/MachO/CMakeFiles/lldMachO.dir/DriverUtils.cpp.o
731.419 [1024/67/5884] Building CXX object tools/clang/tools/extra/clang-tidy/misc/CMakeFiles/obj.clangTidyMiscModule.dir/NewDeleteOverloadsCheck.cpp.o
731.596 [1024/66/5885] Building CXX object tools/clang/tools/extra/clangd/CMakeFiles/obj.clangDaemon.dir/CollectMacros.cpp.o
731.615 [1024/65/5886] Building CXX object tools/clang/tools/extra/clang-tidy/misc/CMakeFiles/obj.clangTidyMiscModule.dir/MisleadingIdentifier.cpp.o
731.807 [1024/64/5887] Building CXX object tools/clang/tools/extra/clang-tidy/misc/CMakeFiles/obj.clangTidyMiscModule.dir/UseInternalLinkageCheck.cpp.o
731.826 [1024/63/5888] Building CXX object tools/lld/wasm/CMakeFiles/lldWasm.dir/SyntheticSections.cpp.o

```

</details>

https://github.com/llvm/llvm-project/pull/107494