[clang] [Clang][ASTMatchers] Add visibility macros to variables declared by macros (PR #110206)
via cfe-commits
cfe-commits at lists.llvm.org
Thu Sep 26 21:35:34 PDT 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-clang
Author: Thomas Fransham (fsfod)
<details>
<summary>Changes</summary>
This will fix missing symbols for ASTMatchersTests on windows when building with CLANG_LINK_CLANG and explicit visibility macros are used. This PR depends on macros that will be be added in #<!-- -->108276
This is part of the work to enable LLVM_BUILD_LLVM_DYLIB and LLVM\Clang plugins on window.
---
Full diff: https://github.com/llvm/llvm-project/pull/110206.diff
1 Files Affected:
- (modified) clang/include/clang/ASTMatchers/ASTMatchersMacros.h (+4-2)
``````````diff
diff --git a/clang/include/clang/ASTMatchers/ASTMatchersMacros.h b/clang/include/clang/ASTMatchers/ASTMatchersMacros.h
index 592a3898a29591..f781e0a565eb36 100644
--- a/clang/include/clang/ASTMatchers/ASTMatchersMacros.h
+++ b/clang/include/clang/ASTMatchers/ASTMatchersMacros.h
@@ -49,6 +49,8 @@
#ifndef LLVM_CLANG_ASTMATCHERS_ASTMATCHERSMACROS_H
#define LLVM_CLANG_ASTMATCHERS_ASTMATCHERSMACROS_H
+#include "clang/Support/Compiler.h"
+
/// AST_MATCHER_FUNCTION(ReturnType, DefineMatcher) { ... }
/// defines a zero parameter function named DefineMatcher() that returns a
/// ReturnType object.
@@ -367,7 +369,7 @@
static QualType (T::*value())() const { return &T::FunctionName; } \
}; \
} \
- extern const ::clang::ast_matchers::internal:: \
+ CLANG_ABI extern const ::clang::ast_matchers::internal:: \
TypeTraversePolymorphicMatcher< \
QualType, \
::clang::ast_matchers::internal::TypeMatcher##MatcherName##Getter, \
@@ -407,7 +409,7 @@
static TypeLoc (T::*value())() const { return &T::FunctionName##Loc; } \
}; \
} \
- extern const ::clang::ast_matchers::internal:: \
+ CLANG_ABI extern const ::clang::ast_matchers::internal:: \
TypeTraversePolymorphicMatcher< \
TypeLoc, \
::clang::ast_matchers::internal:: \
``````````
</details>
https://github.com/llvm/llvm-project/pull/110206
More information about the cfe-commits
mailing list