[clang] [clang] Use std::optional::value_or (NFC) (PR #109894)

Kazu Hirata via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 26 19:13:58 PDT 2024


kazutakahirata wrote:

> Next time please provide a better summary for your PR. This is super important for downstream folks debugging build breaks. In general this is important for reviews to compare what they expect with the actual diff.
> 
> 
> 
> In this case something like "replace the use of conditional operator on std::optional w/ value_or" would have been sufficient. 
> 
> 
> 
> Thank you

Ack.

https://github.com/llvm/llvm-project/pull/109894


More information about the cfe-commits mailing list