[clang-tools-extra] [clang-tidy] Create bugprone-bit-cast-pointers check (PR #108083)

[Julian Schmidt via cfe-commits]

================
@@ -0,0 +1,45 @@
+//===--- BitCastPointersCheck.cpp - clang-tidy ----------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#include "BitCastPointersCheck.h"
+#include "clang/ASTMatchers/ASTMatchFinder.h"
+
+using namespace clang::ast_matchers;
+
+namespace clang::tidy::bugprone {
+
+void BitCastPointersCheck::registerMatchers(MatchFinder *Finder) {
+  auto IsPointerType = refersToType(qualType(isAnyPointer()));
+  Finder->addMatcher(callExpr(hasDeclaration(functionDecl(allOf(
+                                  hasName("::std::bit_cast"),
+                                  hasTemplateArgument(0, IsPointerType),
+                                  hasTemplateArgument(1, IsPointerType)))))
+                         .bind("bit_cast"),
+                     this);
+
+  auto IsDoublePointerType =
+      hasType(qualType(pointsTo(qualType(isAnyPointer()))));
+  Finder->addMatcher(callExpr(hasArgument(0, IsDoublePointerType),
+                              hasArgument(1, IsDoublePointerType),
+                              hasDeclaration(functionDecl(hasName("::memcpy"))))
+                         .bind("memcpy"),
+                     this);
+}
+
+void BitCastPointersCheck::check(const MatchFinder::MatchResult &Result) {
+  if (const auto *MatchedDecl = Result.Nodes.getNodeAs<CallExpr>("bit_cast"))
+    diag(MatchedDecl->getBeginLoc(),
+         "do not use std::bit_cast to cast between pointers")
+        << MatchedDecl->getSourceRange();
+  if (const auto *MatchedDecl = Result.Nodes.getNodeAs<CallExpr>("memcpy"))
+    diag(MatchedDecl->getBeginLoc(),
+         "do not use memcpy to cast between pointers")
+        << MatchedDecl->getSourceRange();
+}
----------------
5chmidti wrote:

Nit: Please wrap `std::bit_cast` and `memcpy` in the diagnostics with `'`.

https://github.com/llvm/llvm-project/pull/108083