[clang] [Clang] Update Interpreter tests to use clang_target_link_libraries (PR #110154)
via cfe-commits
cfe-commits at lists.llvm.org
Thu Sep 26 11:29:55 PDT 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-clang
Author: Thomas Fransham (fsfod)
<details>
<summary>Changes</summary>
This will fix duplicate and missing linker symbol errors when using CLANG_LINK_CLANG_DYLIB on windows and explicit visibility macros are used.
This is part of the work to enable LLVM_BUILD_LLVM_DYLIB and plugins on window.
---
Full diff: https://github.com/llvm/llvm-project/pull/110154.diff
1 Files Affected:
- (modified) clang/unittests/Interpreter/CMakeLists.txt (+4-2)
``````````diff
diff --git a/clang/unittests/Interpreter/CMakeLists.txt b/clang/unittests/Interpreter/CMakeLists.txt
index ec6f81ea19b960..1ed1216c772e8f 100644
--- a/clang/unittests/Interpreter/CMakeLists.txt
+++ b/clang/unittests/Interpreter/CMakeLists.txt
@@ -16,13 +16,15 @@ add_clang_unittest(ClangReplInterpreterTests
EXPORT_SYMBOLS
)
-target_link_libraries(ClangReplInterpreterTests PUBLIC
+
+target_link_libraries(ClangReplInterpreterTests PUBLIC LLVMTestingSupport)
+
+clang_target_link_libraries(ClangReplInterpreterTests PRIVATE
clangAST
clangBasic
clangInterpreter
clangFrontend
clangSema
- LLVMTestingSupport
)
# Exceptions on Windows are not yet supported.
``````````
</details>
https://github.com/llvm/llvm-project/pull/110154
More information about the cfe-commits
mailing list