[clang] [clang-tools-extra] [NFC] Add implicit cast kinds for function pointer conversions (PR #110048)

via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 25 15:03:13 PDT 2024


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff 4db0cc4c5582c73eb793572f8a8d5892b05fdfde 75cd73ecda039750270e8bde0523f51e4698c4ea --extensions cpp,h -- clang/test/AST/ast-dump-function-pointer-conversion.cpp clang-tools-extra/clang-tidy/bugprone/SwappedArgumentsCheck.cpp clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeCstyleCastCheck.cpp clang-tools-extra/clang-tidy/google/AvoidCStyleCastsCheck.cpp clang-tools-extra/clang-tidy/modernize/LoopConvertCheck.cpp clang-tools-extra/clang-tidy/performance/ImplicitConversionInLoopCheck.cpp clang-tools-extra/clang-tidy/readability/MakeMemberFunctionConstCheck.cpp clang-tools-extra/clang-tidy/utils/DeclRefExprUtils.cpp clang-tools-extra/clangd/Hover.cpp clang/include/clang/AST/IgnoreExpr.h clang/lib/ARCMigrate/TransBlockObjCVariable.cpp clang/lib/AST/ByteCode/Compiler.cpp clang/lib/AST/Expr.cpp clang/lib/AST/ExprCXX.cpp clang/lib/AST/ExprConstant.cpp clang/lib/Analysis/CFG.cpp clang/lib/Analysis/ExprMutationAnalyzer.cpp clang/lib/Analysis/FlowSensitive/Transfer.cpp clang/lib/Analysis/ThreadSafety.cpp clang/lib/Analysis/ThreadSafetyCommon.cpp clang/lib/CodeGen/CGDecl.cpp clang/lib/CodeGen/CGExpr.cpp clang/lib/CodeGen/CGExprAgg.cpp clang/lib/CodeGen/CGExprComplex.cpp clang/lib/CodeGen/CGExprConstant.cpp clang/lib/CodeGen/CGExprScalar.cpp clang/lib/Edit/RewriteObjCFoundationAPI.cpp clang/lib/Sema/CheckExprLifetime.cpp clang/lib/Sema/SemaChecking.cpp clang/lib/Sema/SemaDecl.cpp clang/lib/Sema/SemaDeclCXX.cpp clang/lib/Sema/SemaExpr.cpp clang/lib/Sema/SemaExprCXX.cpp clang/lib/Sema/SemaInit.cpp clang/lib/Sema/SemaOverload.cpp clang/lib/Sema/SemaStmt.cpp clang/lib/StaticAnalyzer/Core/ExprEngineC.cpp clang/lib/StaticAnalyzer/Core/SValBuilder.cpp clang/test/CXX/dcl.decl/dcl.init/dcl.init.ref/p4-ast.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/clang/lib/Analysis/ThreadSafety.cpp b/clang/lib/Analysis/ThreadSafety.cpp
index 49883e01f7..8c3396e2d9 100644
--- a/clang/lib/Analysis/ThreadSafety.cpp
+++ b/clang/lib/Analysis/ThreadSafety.cpp
@@ -2106,7 +2106,7 @@ static const Expr *UnpackConstruction(const Expr *E) {
     if (CE->getCastKind() == CK_NoOp ||
         CE->getCastKind() == CK_FunctionPointerConversion ||
         CE->getCastKind() == CK_MemberFunctionPointerConversion)
-        E = CE->getSubExpr()->IgnoreParens();
+      E = CE->getSubExpr()->IgnoreParens();
   if (auto *CE = dyn_cast<CastExpr>(E))
     if (CE->getCastKind() == CK_ConstructorConversion ||
         CE->getCastKind() == CK_UserDefinedConversion)

``````````

</details>


https://github.com/llvm/llvm-project/pull/110048


More information about the cfe-commits mailing list