[clang] WebKit Checkers should set DeclWithIssue. (PR #109389)

Artem Dergachev via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 25 14:02:34 PDT 2024


================
@@ -56,12 +62,16 @@ class UncountedCallArgsChecker
       bool TraverseClassTemplateDecl(ClassTemplateDecl *Decl) {
         if (isRefType(safeGetName(Decl)))
           return true;
-        return RecursiveASTVisitor<LocalVisitor>::TraverseClassTemplateDecl(
-            Decl);
+        return Base::TraverseClassTemplateDecl(Decl);
+      }
+
+      bool TraverseDecl(Decl *D) {
----------------
haoNoQ wrote:

With this blanket "let's catch every decl" code it may catch a few very weird decls here and there (eg `VarDecl`, `BlockDecl`, etc). I don't know what the exact consequences of that look. They're probably benign. But it's probably easier to stick to `FunctionDecl` and `ObjCMethodDecl`.

https://github.com/llvm/llvm-project/pull/109389


More information about the cfe-commits mailing list