[clang] [llvm] Deprecate the `-fbasic-block-sections=labels` option. (PR #107494)

Wed Sep 25 14:00:15 PDT 2024

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `lld-x86_64-ubuntu-fast` running on `as-builder-4` while building `clang,llvm` at step 5 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/33/builds/3738

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 5 (build-unified-tree) failure: build (failure)
...
267.080 [133/64/3608] Building CXX object tools/lto/CMakeFiles/LTO.dir/lto.cpp.o
267.940 [132/64/3609] Linking CXX executable bin/llvm-objdump
267.962 [131/64/3610] Generating ../../bin/llvm-otool
268.264 [130/64/3611] Building CXX object tools/llvm-isel-fuzzer/CMakeFiles/llvm-isel-fuzzer.dir/llvm-isel-fuzzer.cpp.o
/home/buildbot/worker/as-builder-4/ramdisk/lld-x86_64/llvm-project/llvm/tools/llvm-isel-fuzzer/llvm-isel-fuzzer.cpp: In function ‘int LLVMFuzzerInitialize(int*, char***)’:
/home/buildbot/worker/as-builder-4/ramdisk/lld-x86_64/llvm-project/llvm/tools/llvm-isel-fuzzer/llvm-isel-fuzzer.cpp:141:43: warning: ISO C++ forbids zero-size array ‘argv’ [-Wpedantic]
  141 |   ExitOnError ExitOnErr(std::string(*argv[0]) + ": error:");
      |                                           ^
268.801 [129/64/3612] Linking CXX executable bin/llvm-profgen
269.379 [128/64/3613] Building CXX object tools/lld/ELF/CMakeFiles/lldELF.dir/LTO.cpp.o
FAILED: tools/lld/ELF/CMakeFiles/lldELF.dir/LTO.cpp.o 
CCACHE_CPP2=yes CCACHE_HASHDIR=yes /usr/bin/ccache /usr/bin/c++ -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/buildbot/worker/as-builder-4/ramdisk/lld-x86_64/build/tools/lld/ELF -I/home/buildbot/worker/as-builder-4/ramdisk/lld-x86_64/llvm-project/lld/ELF -I/home/buildbot/worker/as-builder-4/ramdisk/lld-x86_64/llvm-project/lld/include -I/home/buildbot/worker/as-builder-4/ramdisk/lld-x86_64/build/tools/lld/include -I/home/buildbot/worker/as-builder-4/ramdisk/lld-x86_64/build/include -I/home/buildbot/worker/as-builder-4/ramdisk/lld-x86_64/llvm-project/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -fno-lifetime-dse -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -std=c++17 -MD -MT tools/lld/ELF/CMakeFiles/lldELF.dir/LTO.cpp.o -MF tools/lld/ELF/CMakeFiles/lldELF.dir/LTO.cpp.o.d -o tools/lld/ELF/CMakeFiles/lldELF.dir/LTO.cpp.o -c /home/buildbot/worker/as-builder-4/ramdisk/lld-x86_64/llvm-project/lld/ELF/LTO.cpp
/home/buildbot/worker/as-builder-4/ramdisk/lld-x86_64/llvm-project/lld/ELF/LTO.cpp: In function ‘llvm::lto::Config createConfig(lld::elf::Ctx&)’:
/home/buildbot/worker/as-builder-4/ramdisk/lld-x86_64/llvm-project/lld/ELF/LTO.cpp:74:49: error: ‘Labels’ is not a member of ‘llvm::BasicBlockSection’
   74 |       c.Options.BBSections = BasicBlockSection::Labels;
      |                                                 ^~~~~~
269.406 [128/63/3614] Building CXX object tools/llvm-reduce/CMakeFiles/llvm-reduce.dir/TestRunner.cpp.o
269.831 [128/62/3615] Building CXX object lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/GISel/X86LegalizerInfo.cpp.o
270.138 [128/61/3616] Building CXX object tools/lld/COFF/CMakeFiles/lldCOFF.dir/LTO.cpp.o
270.663 [128/60/3617] Building CXX object tools/llvm-reduce/CMakeFiles/llvm-reduce.dir/deltas/ReduceInstructionFlags.cpp.o
270.690 [128/59/3618] Building CXX object tools/lld/wasm/CMakeFiles/lldWasm.dir/OutputSections.cpp.o
270.939 [128/58/3619] Building CXX object tools/llvm-reduce/CMakeFiles/llvm-reduce.dir/deltas/ReduceDistinctMetadata.cpp.o
270.946 [128/57/3620] Building CXX object tools/lld/wasm/CMakeFiles/lldWasm.dir/InputChunks.cpp.o
271.060 [128/56/3621] Building CXX object tools/lld/wasm/CMakeFiles/lldWasm.dir/MarkLive.cpp.o
271.166 [128/55/3622] Building CXX object tools/lld/wasm/CMakeFiles/lldWasm.dir/LTO.cpp.o
271.224 [128/54/3623] Building CXX object lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86CodeGenPassBuilder.cpp.o
271.309 [128/53/3624] Building CXX object tools/llvm-reduce/CMakeFiles/llvm-reduce.dir/deltas/ReduceAttributes.cpp.o
271.458 [128/52/3625] Building CXX object tools/llvm-reduce/CMakeFiles/llvm-reduce.dir/deltas/ReduceInvokes.cpp.o
272.101 [128/51/3626] Building CXX object tools/lld/wasm/CMakeFiles/lldWasm.dir/OutputSegment.cpp.o
272.122 [128/50/3627] Building CXX object tools/lld/wasm/CMakeFiles/lldWasm.dir/Driver.cpp.o
272.354 [128/49/3628] Building CXX object tools/llvm-reduce/CMakeFiles/llvm-reduce.dir/DeltaManager.cpp.o
272.399 [128/48/3629] Building CXX object tools/llvm-reduce/CMakeFiles/llvm-reduce.dir/deltas/ReduceMetadata.cpp.o
272.597 [128/47/3630] Building CXX object tools/llvm-reduce/CMakeFiles/llvm-reduce.dir/deltas/ReduceDIMetadata.cpp.o
272.599 [128/46/3631] Building CXX object tools/lld/MachO/CMakeFiles/lldMachO.dir/DriverUtils.cpp.o
272.636 [128/45/3632] Building CXX object tools/llvm-reduce/CMakeFiles/llvm-reduce.dir/deltas/ReduceInstructionFlagsMIR.cpp.o
272.716 [128/44/3633] Building CXX object tools/lld/MachO/CMakeFiles/lldMachO.dir/LTO.cpp.o
272.755 [128/43/3634] Building CXX object tools/llvm-lto/CMakeFiles/llvm-lto.dir/llvm-lto.cpp.o
272.802 [128/42/3635] Building CXX object tools/llvm-reduce/CMakeFiles/llvm-reduce.dir/deltas/ReduceMemoryOperations.cpp.o
272.841 [128/41/3636] Building CXX object tools/lld/wasm/CMakeFiles/lldWasm.dir/Relocations.cpp.o
273.044 [128/40/3637] Building CXX object tools/llvm-reduce/CMakeFiles/llvm-reduce.dir/deltas/ReduceIRReferences.cpp.o
273.133 [128/39/3638] Building CXX object lib/Target/RISCV/CMakeFiles/LLVMRISCVCodeGen.dir/RISCVVectorPeephole.cpp.o
273.151 [128/38/3639] Building CXX object tools/llvm-reduce/CMakeFiles/llvm-reduce.dir/deltas/ReduceRegisterUses.cpp.o
273.187 [128/37/3640] Building CXX object tools/lld/COFF/CMakeFiles/lldCOFF.dir/SymbolTable.cpp.o
273.314 [128/36/3641] Building CXX object tools/llvm-reduce/CMakeFiles/llvm-reduce.dir/deltas/ReduceVirtualRegisters.cpp.o
273.413 [128/35/3642] Building CXX object lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/GISel/X86InstructionSelector.cpp.o
273.468 [128/34/3643] Building CXX object tools/dsymutil/CMakeFiles/dsymutil.dir/dsymutil.cpp.o
273.482 [128/33/3644] Building CXX object tools/llvm-dwarfutil/CMakeFiles/llvm-dwarfutil.dir/DebugInfoLinker.cpp.o
273.683 [128/32/3645] Building CXX object tools/lld/wasm/CMakeFiles/lldWasm.dir/Symbols.cpp.o
273.703 [128/31/3646] Building CXX object tools/llvm-reduce/CMakeFiles/llvm-reduce.dir/deltas/ReduceOpcodes.cpp.o

```

</details>

https://github.com/llvm/llvm-project/pull/107494