[clang] [llvm] Deprecate the `-fbasic-block-sections=labels` option. (PR #107494)

Wed Sep 25 12:34:28 PDT 2024

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-sie-win` running on `sie-win-worker` while building `clang,llvm` at step 6 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/46/builds/5534

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 6 (build-unified-tree) failure: build (failure)
...
[2786/4713] Building CXX object tools\clang\lib\AST\CMakeFiles\obj.clangAST.dir\DeclObjC.cpp.obj
[2787/4713] Building CXX object tools\clang\lib\AST\CMakeFiles\obj.clangAST.dir\CXXInheritance.cpp.obj
[2788/4713] Building CXX object tools\lld\wasm\CMakeFiles\lldWasm.dir\Writer.cpp.obj
[2789/4713] Building CXX object tools\clang\lib\AST\CMakeFiles\obj.clangAST.dir\ComputeDependence.cpp.obj
[2790/4713] Building CXX object tools\lld\COFF\CMakeFiles\lldCOFF.dir\Driver.cpp.obj
[2791/4713] Building CXX object tools\lld\MachO\CMakeFiles\lldMachO.dir\Driver.cpp.obj
[2792/4713] Building CXX object tools\lld\wasm\CMakeFiles\lldWasm.dir\SymbolTable.cpp.obj
[2793/4713] Building CXX object tools\clang\lib\AST\CMakeFiles\obj.clangAST.dir\ByteCode\DynamicAllocator.cpp.obj
[2794/4713] Building CXX object tools\lld\wasm\CMakeFiles\lldWasm.dir\Relocations.cpp.obj
[2795/4713] Building CXX object tools\lld\ELF\CMakeFiles\lldELF.dir\LTO.cpp.obj
FAILED: tools/lld/ELF/CMakeFiles/lldELF.dir/LTO.cpp.obj 
C:\bin\ccache.exe C:\PROGRA~2\MICROS~1\2019\BUILDT~1\VC\Tools\MSVC\1429~1.301\bin\HostX64\x64\cl.exe  /nologo /TP -DGTEST_HAS_RTTI=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_GLIBCXX_ASSERTIONS -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Itools\lld\ELF -IZ:\b\llvm-clang-x86_64-sie-win\llvm-project\lld\ELF -IZ:\b\llvm-clang-x86_64-sie-win\llvm-project\lld\include -Itools\lld\include -Iinclude -IZ:\b\llvm-clang-x86_64-sie-win\llvm-project\llvm\include /DWIN32 /D_WINDOWS   /Zc:inline /Zc:preprocessor /Zc:__cplusplus /Oi /bigobj /permissive- /W4 -wd4141 -wd4146 -wd4244 -wd4267 -wd4291 -wd4351 -wd4456 -wd4457 -wd4458 -wd4459 -wd4503 -wd4624 -wd4722 -wd4100 -wd4127 -wd4512 -wd4505 -wd4610 -wd4510 -wd4702 -wd4245 -wd4706 -wd4310 -wd4701 -wd4703 -wd4389 -wd4611 -wd4805 -wd4204 -wd4577 -wd4091 -wd4592 -wd4319 -wd4709 -wd5105 -wd4324 -wd4251 -wd4275 -w14062 -we4238 /Gw /O2 /Ob2  -MD   -wd4530 -wd4062  /EHs-c- /GR- -UNDEBUG -std:c++17 /showIncludes /Fotools\lld\ELF\CMakeFiles\lldELF.dir\LTO.cpp.obj /Fdtools\lld\ELF\CMakeFiles\lldELF.dir\lldELF.pdb /FS -c Z:\b\llvm-clang-x86_64-sie-win\llvm-project\lld\ELF\LTO.cpp
Z:\b\llvm-clang-x86_64-sie-win\llvm-project\lld\ELF\LTO.cpp(74): error C2838: 'Labels': illegal qualified name in member declaration
Z:\b\llvm-clang-x86_64-sie-win\llvm-project\lld\ELF\LTO.cpp(74): error C2065: 'Labels': undeclared identifier
[2796/4713] Building CXX object tools\clang\lib\AST\CMakeFiles\obj.clangAST.dir\ByteCode\PrimType.cpp.obj
[2797/4713] Building CXX object tools\clang\lib\AST\CMakeFiles\obj.clangAST.dir\ExternalASTSource.cpp.obj
[2798/4713] Building CXX object tools\lld\MachO\CMakeFiles\lldMachO.dir\LTO.cpp.obj
[2799/4713] Building CXX object tools\clang\lib\AST\CMakeFiles\obj.clangAST.dir\ByteCode\InterpBlock.cpp.obj
[2800/4713] Building CXX object tools\clang\lib\AST\CMakeFiles\obj.clangAST.dir\DeclFriend.cpp.obj
[2801/4713] Building CXX object tools\lld\wasm\CMakeFiles\lldWasm.dir\OutputSections.cpp.obj
[2802/4713] Building CXX object tools\clang\lib\AST\CMakeFiles\obj.clangAST.dir\ByteCode\MemberPointer.cpp.obj
[2803/4713] Building CXX object tools\clang\lib\AST\CMakeFiles\obj.clangAST.dir\ByteCode\InterpState.cpp.obj
[2804/4713] Building CXX object tools\lld\wasm\CMakeFiles\lldWasm.dir\Symbols.cpp.obj
[2805/4713] Building CXX object tools\lld\wasm\CMakeFiles\lldWasm.dir\OutputSegment.cpp.obj
[2806/4713] Building CXX object tools\lld\wasm\CMakeFiles\lldWasm.dir\Driver.cpp.obj
[2807/4713] Building CXX object tools\clang\lib\AST\CMakeFiles\obj.clangAST.dir\ASTImporterLookupTable.cpp.obj
[2808/4713] Building CXX object tools\clang\lib\AST\CMakeFiles\obj.clangAST.dir\Decl.cpp.obj
[2809/4713] Building CXX object tools\clang\lib\AST\CMakeFiles\obj.clangAST.dir\ExternalASTMerger.cpp.obj
[2810/4713] Building CXX object tools\clang\lib\AST\CMakeFiles\obj.clangAST.dir\DeclBase.cpp.obj
[2811/4713] Building CXX object tools\lld\wasm\CMakeFiles\lldWasm.dir\MapFile.cpp.obj
[2812/4713] Building CXX object tools\clang\lib\AST\CMakeFiles\obj.clangAST.dir\ByteCode\Source.cpp.obj
[2813/4713] Building CXX object tools\clang\lib\AST\CMakeFiles\obj.clangAST.dir\AttrImpl.cpp.obj
[2814/4713] Building CXX object tools\lld\MachO\CMakeFiles\lldMachO.dir\DriverUtils.cpp.obj
[2815/4713] Building CXX object tools\clang\lib\AST\CMakeFiles\obj.clangAST.dir\DeclCXX.cpp.obj
[2816/4713] Building CXX object tools\clang\lib\AST\CMakeFiles\obj.clangAST.dir\MicrosoftCXXABI.cpp.obj
[2817/4713] Building CXX object tools\lld\MachO\CMakeFiles\lldMachO.dir\InputFiles.cpp.obj
[2818/4713] Building CXX object tools\clang\lib\AST\CMakeFiles\obj.clangAST.dir\ByteCode\InterpShared.cpp.obj
[2819/4713] Building CXX object tools\clang\lib\AST\CMakeFiles\obj.clangAST.dir\ExprClassification.cpp.obj
[2820/4713] Building CXX object tools\clang\lib\AST\CMakeFiles\obj.clangAST.dir\OSLog.cpp.obj
[2821/4713] Building CXX object tools\clang\lib\AST\CMakeFiles\obj.clangAST.dir\ExprObjC.cpp.obj
[2822/4713] Building CXX object tools\lld\ELF\CMakeFiles\lldELF.dir\InputFiles.cpp.obj
[2823/4713] Building CXX object tools\clang\lib\AST\CMakeFiles\obj.clangAST.dir\ByteCode\Descriptor.cpp.obj
[2824/4713] Building CXX object tools\clang\lib\AST\CMakeFiles\obj.clangAST.dir\OpenACCClause.cpp.obj
[2825/4713] Building CXX object tools\clang\lib\AST\CMakeFiles\obj.clangAST.dir\ExprCXX.cpp.obj
[2826/4713] Building CXX object tools\clang\lib\AST\CMakeFiles\obj.clangAST.dir\ByteCode\Record.cpp.obj
[2827/4713] Building CXX object tools\clang\lib\AST\CMakeFiles\obj.clangAST.dir\OpenMPClause.cpp.obj
[2828/4713] Building CXX object tools\clang\lib\AST\CMakeFiles\obj.clangAST.dir\ByteCode\Function.cpp.obj
[2829/4713] Building CXX object tools\clang\lib\AST\CMakeFiles\obj.clangAST.dir\ItaniumCXXABI.cpp.obj
[2830/4713] Building CXX object tools\clang\lib\AST\CMakeFiles\obj.clangAST.dir\ByteCode\InterpStack.cpp.obj

```

</details>

https://github.com/llvm/llvm-project/pull/107494