[clang] [analyzer] Suppress out of bounds reports after weak loop assumptions (PR #109804)

[via cfe-commits]

=?utf-8?q?Donát?= Nagy <donat.nagy at ericsson.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/109804 at github.com>


https://github.com/isuckatcs requested changes to this pull request.

If I understand it correctly, we want to use (very likely) incorrect assumptions to suppress false positives produced by an alpha checker, which receives otherwise wrong assumptions. 

I feel like this is a situation when someone makes 2 mistakes in a maths test that by chance cancel each other, so they end up getting the correct result. However in that case the solution is still not accepted, because the calculation was wrong.

I think the correct solution to this problem is to investigate why the specific checker receives wrong existing assumptions and make those assumptions correct.

https://github.com/llvm/llvm-project/pull/109804