[clang] [llvm] [AMDGPU] Convert AMDGPUResourceUsageAnalysis pass from Module to MF pass (PR #102913)

Scott Linder via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 23 14:36:28 PDT 2024


================
@@ -1755,6 +1755,56 @@ As part of the AMDGPU MC layer, AMDGPU provides the following target specific
 
      =================== ================= ========================================================
 
+Function Resource Usage
+-----------------------
+
+The function resource information (e.g., number of VGPRs) required depends on
----------------
slinder1 wrote:

Nit, I would use an indefinite article to start this sentence, since it is talking about "any"/"every" function rather than a particular function. I also think consistently referring to "resource usage" rather than "resource information" would help, and the parenthetical example breaks things up too much IMO.

```
A function's resource usage depends on each of its callees' resource usage. The expressions used to denote resource usage reflect this by propagating each callees' equivalent expressions. Said expressions ...
```

https://github.com/llvm/llvm-project/pull/102913


More information about the cfe-commits mailing list