[clang] 68e2b69 - [NvlinkWrapper] Fix `-pluing` not consuming its argument

Joseph Huber via cfe-commits cfe-commits at lists.llvm.org
Sun Sep 22 06:04:26 PDT 2024


Author: Joseph Huber
Date: 2024-09-22T08:04:20-05:00
New Revision: 68e2b695eae06b42261ecdc145c1f1ece57cd14c

URL: https://github.com/llvm/llvm-project/commit/68e2b695eae06b42261ecdc145c1f1ece57cd14c
DIFF: https://github.com/llvm/llvm-project/commit/68e2b695eae06b42261ecdc145c1f1ece57cd14c.diff

LOG: [NvlinkWrapper] Fix `-pluing` not consuming its argument

Summary:
Sometimes `clang` will pass `-plugin` when doing LTO, which should be
correctly consumed by the nvlink wrapper. Right now it was leaving the
`plugin.so` argument as a regular input, which would cause it to error
on the `.so` input.

Added: 
    

Modified: 
    clang/tools/clang-nvlink-wrapper/NVLinkOpts.td

Removed: 
    


################################################################################
diff  --git a/clang/tools/clang-nvlink-wrapper/NVLinkOpts.td b/clang/tools/clang-nvlink-wrapper/NVLinkOpts.td
index ef1a7542e49502..eeb9d1a6228240 100644
--- a/clang/tools/clang-nvlink-wrapper/NVLinkOpts.td
+++ b/clang/tools/clang-nvlink-wrapper/NVLinkOpts.td
@@ -39,7 +39,7 @@ def library_S : Separate<["--", "-"], "library">, Flags<[HelpHidden]>,
 def library_EQ : Joined<["--", "-"], "library=">, Flags<[HelpHidden]>,
   Alias<library_path>;
 
-def plugin : Joined<["--", "-"], "plugin">, 
+def plugin : JoinedOrSeparate<["--", "-"], "plugin">,
   Flags<[HelpHidden, WrapperOnlyOption]>;
 
 def arch : Separate<["--", "-"], "arch">,


        


More information about the cfe-commits mailing list