[clang] [llvm] Add cross builtins and cross HLSL function to DirectX and SPIR-V backend (PR #109180)

Farzon Lotfi via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 20 12:37:46 PDT 2024


================
@@ -1704,6 +1704,20 @@ bool SemaHLSL::CheckBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) {
       return true;
     break;
   }
+  case Builtin::BI__builtin_hlsl_cross: {
+    if (SemaRef.checkArgCount(TheCall, 2))
+      return true;
+    if (CheckVectorElementCallArgs(&SemaRef, TheCall))
+      return true;
+    if (CheckFloatOrHalfRepresentations(&SemaRef, TheCall))
+      return true;
+
----------------
farzonl wrote:

Maybe we should do a  vector size check to prevent misuse of the builtin? Downsize is the check isn't triggerable from the hlsl function name.

https://github.com/llvm/llvm-project/pull/109180


More information about the cfe-commits mailing list