[clang] [Clang] Include the clang-shlib CMake project when building for MSVC (PR #109457)
via cfe-commits
cfe-commits at lists.llvm.org
Fri Sep 20 11:34:18 PDT 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-clang
Author: Thomas Fransham (fsfod)
<details>
<summary>Changes</summary>
Enable building clang-cpp shared library for windows when building with explicit visibility macros enabled and LLVM is built as a shared library(LLVM_BUILD_LLVM_DYLIB_VIS).
This is part of the effort to support for enabling plugins on windows by adding better support for building LLVM and Clang as a DLL.
---
Full diff: https://github.com/llvm/llvm-project/pull/109457.diff
1 Files Affected:
- (modified) clang/tools/CMakeLists.txt (+1-1)
``````````diff
diff --git a/clang/tools/CMakeLists.txt b/clang/tools/CMakeLists.txt
index 9a3512712a28a4..88e29412e54350 100644
--- a/clang/tools/CMakeLists.txt
+++ b/clang/tools/CMakeLists.txt
@@ -22,7 +22,7 @@ add_clang_subdirectory(c-index-test)
add_clang_subdirectory(clang-refactor)
# For MinGW we only enable shared library if LLVM_LINK_LLVM_DYLIB=ON.
# Without that option resulting library is too close to 2^16 DLL exports limit.
-if(UNIX OR (MINGW AND LLVM_LINK_LLVM_DYLIB))
+if(UNIX OR (MSVC AND LLVM_BUILD_LLVM_DYLIB_VIS) OR (MINGW AND LLVM_LINK_LLVM_DYLIB))
add_clang_subdirectory(clang-shlib)
endif()
``````````
</details>
https://github.com/llvm/llvm-project/pull/109457
More information about the cfe-commits
mailing list