[clang] [clang-tools-extra] [lldb] [llvm] [SystemZ][z/OS] Propagate IsText parameter to open text files as text (PR #107906)
kadir çetinkaya via cfe-commits
cfe-commits at lists.llvm.org
Fri Sep 20 05:10:58 PDT 2024
kadircet wrote:
i've also just noticed https://github.com/llvm/llvm-project/commit/3b3accb598ec87a6a30b0e18ded06071030bb78f, which seem to be pushed without review and any tests, changing behavior more in a non-obvious way. Please not that logic you have in:
```
Expected<file_t> FDOrErr = sys::fs::openNativeFileForRead(
adjustPath(Name, Storage), IsText ? sys::fs::OF_Text : sys::fs::OF_None,
&RealName);
```
is affecting all, not just zOS, and by fiddling with the value passed by default, you're in turn changing the flags used by all the platforms.
https://github.com/llvm/llvm-project/pull/107906
More information about the cfe-commits
mailing list